[15.0][MIG] mail_drop_target #881

JasminSForgeFlow · 2022-04-04T08:57:26Z

Standard Migration

Adapt Odoo's out-of-box dropzone functionality, and remove the dependency of web_drop_target.

oca-clabot · 2022-04-04T08:57:28Z

Hey @JasminSForgeFlow, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Jairo Llopis jairo.llopis@tecnativa.com (no github login found)

Appreciation of efforts,
OCA CLAbot

rafaelbn · 2022-04-07T19:31:33Z

/ocabot migration mail_drop_target

etobella · 2022-05-03T15:54:01Z

Why do you want to remove the dependency on web_drop_target? Code was easier if it was dependent IMO

etobella · 2022-05-03T16:02:28Z

I understand you change, so, don't need to keep the dependancy.
However, it is failing un runbot

etobella · 2022-05-03T16:03:26Z

With eml it works fine, but it fails when using msg (taken it from the test files)

ygol · 2022-05-19T12:58:32Z

I think there's a dependency missing (ReferenceError: base64js is not defined):
the library "base64js" that was previously loaded from "web_drop_target".
After adding it to further test:

I tried loading several different msg messages and could get some of them working (plain text email). but most often I get the following error:

Traceback (most recent call last):
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/home/odoo/src/odoo/odoo/http.py", line 687, in dispatch
    result = self._call_function(**self.params)
  File "/home/odoo/src/odoo/odoo/http.py", line 359, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/http.py", line 348, in checked_call
    result = self.endpoint(*a, **kw)
  File "/home/odoo/src/odoo/odoo/http.py", line 916, in __call__
    return self.method(*args, **kw)
  File "/home/odoo/src/odoo/odoo/http.py", line 535, in response_wrap
    response = f(*args, **kw)
  File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1347, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1339, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/home/odoo/src/odoo/odoo/api.py", line 460, in call_kw
    result = _call_kw_model(method, model, args, kwargs)
  File "/home/odoo/src/odoo/odoo/api.py", line 433, in _call_kw_model
    result = method(recs, *args, **kwargs)
  File "/home/odoo/src/user/mail_drop_target/models/mail_thread.py", line 90, in message_process_msg
    message_email = self.env["ir.mail_server"].build_email(
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_mail_server.py", line 422, in build_email
    for (fname, fcontent, mime) in attachments:
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/odoo/src/odoo/odoo/http.py", line 643, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/home/odoo/src/odoo/odoo/http.py", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
ValueError: not enough values to unpack (expected 3, got 2)

Also got from a different messages:

Traceback (most recent call last):
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/home/odoo/src/odoo/odoo/http.py", line 687, in dispatch
    result = self._call_function(**self.params)
  File "/home/odoo/src/odoo/odoo/http.py", line 359, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/http.py", line 348, in checked_call
    result = self.endpoint(*a, **kw)
  File "/home/odoo/src/odoo/odoo/http.py", line 916, in __call__
    return self.method(*args, **kw)
  File "/home/odoo/src/odoo/odoo/http.py", line 535, in response_wrap
    response = f(*args, **kw)
  File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1347, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1339, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/home/odoo/src/odoo/odoo/api.py", line 460, in call_kw
    result = _call_kw_model(method, model, args, kwargs)
  File "/home/odoo/src/odoo/odoo/api.py", line 433, in _call_kw_model
    result = method(recs, *args, **kwargs)
  File "/home/odoo/src/user/mail_drop_target/models/mail_thread.py", line 90, in message_process_msg
    message_email = self.env["ir.mail_server"].build_email(
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_mail_server.py", line 395, in build_email
    msg['Message-Id'] = message_id
  File "/usr/lib/python3.8/email/message.py", line 409, in __setitem__
    self._headers.append(self.policy.header_store_parse(name, val))
  File "/usr/lib/python3.8/email/policy.py", line 146, in header_store_parse
    raise ValueError("Header values may not contain linefeed "
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/odoo/src/odoo/odoo/http.py", line 643, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/home/odoo/src/odoo/odoo/http.py", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
ValueError: Header values may not contain linefeed or carriage return characters

and also

Traceback (most recent call last):
  File "/home/odoo/.local/lib/python3.8/site-packages/extract_msg/msg.py", line 55, in __init__
    super().__init__(path)
  File "/usr/lib/python3/dist-packages/olefile/olefile.py", line 1075, in __init__
    self.open(filename, write_mode=write_mode)
  File "/usr/lib/python3/dist-packages/olefile/olefile.py", line 1192, in open
    self._raise_defect(DEFECT_FATAL, "not an OLE2 structured storage file")
  File "/usr/lib/python3/dist-packages/olefile/olefile.py", line 1105, in _raise_defect
    raise exception_type(message)
OSError: not an OLE2 structured storage file

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/odoo/src/odoo/odoo/addons/base/models/ir_http.py", line 237, in _dispatch
    result = request.dispatch()
  File "/home/odoo/src/odoo/odoo/http.py", line 687, in dispatch
    result = self._call_function(**self.params)
  File "/home/odoo/src/odoo/odoo/http.py", line 359, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/service/model.py", line 94, in wrapper
    return f(dbname, *args, **kwargs)
  File "/home/odoo/src/odoo/odoo/http.py", line 348, in checked_call
    result = self.endpoint(*a, **kw)
  File "/home/odoo/src/odoo/odoo/http.py", line 916, in __call__
    return self.method(*args, **kw)
  File "/home/odoo/src/odoo/odoo/http.py", line 535, in response_wrap
    response = f(*args, **kw)
  File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1347, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/home/odoo/src/odoo/addons/web/controllers/main.py", line 1339, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/home/odoo/src/odoo/odoo/api.py", line 460, in call_kw
    result = _call_kw_model(method, model, args, kwargs)
  File "/home/odoo/src/odoo/odoo/api.py", line 433, in _call_kw_model
    result = method(recs, *args, **kwargs)
  File "/home/odoo/src/user/mail_drop_target/models/mail_thread.py", line 84, in message_process_msg
    message_msg = Message(b64decode(message))
  File "/home/odoo/.local/lib/python3.8/site-packages/extract_msg/message.py", line 26, in __init__
    super().__init__(path, prefix, attachmentClass, filename, delayAttachments, overrideEncoding, attachmentErrorBehavior, recipientSeparator)
  File "/home/odoo/.local/lib/python3.8/site-packages/extract_msg/message_base.py", line 54, in __init__
    super().__init__(path, prefix, attachmentClass, filename, overrideEncoding, attachmentErrorBehavior)
  File "/home/odoo/.local/lib/python3.8/site-packages/extract_msg/msg.py", line 59, in __init__
    raise InvalidFileFormatError(e)
Exception

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/odoo/src/odoo/odoo/http.py", line 643, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/home/odoo/src/odoo/odoo/http.py", line 301, in _handle_exception
    raise exception.with_traceback(None) from new_cause
extract_msg.exceptions.InvalidFileFormatError: not an OLE2 structured storage file

LoisRForgeFlow · 2022-10-03T07:57:50Z

Rebased and fixed conflict.

github-actions · 2023-02-05T12:29:47Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

nguyenminhchien · 2023-08-29T07:53:19Z

Hello @JasminSForgeFlow @LoisRForgeFlow , i just created this PR to import base64js library. Please review.
Thanks,

nguyenminhchien · 2023-08-30T09:02:01Z

@ygol i don't face those errors you had, please share your test files.

LoisRForgeFlow · 2023-09-21T10:14:57Z

Hello @JasminSForgeFlow @LoisRForgeFlow , i just created this PR to import base64js library. Please review. Thanks,

@nguyenminhchien thanks! your commit has been included here.

However, now a test from a different module is failing. I have tried to reproduce the error in my local with both mail_drop_target and mail_composer_cc_bcc installed, but all ran good in my case. Can you try to reproduce in your side?

nguyenminhchien · 2023-09-22T08:46:21Z

However, now a test from a different module is failing. I have tried to reproduce the error in my local with both mail_drop_target and mail_composer_cc_bcc installed, but all ran good in my case. Can you try to reproduce in your side?

@LoisRForgeFlow Pull the latest Odoo codebase, the test will be failed. Here is from my local

github-actions · 2024-01-21T12:28:07Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

…file

…s as attachment

JordiBForgeFlow

👍 Works as expected

JordiBForgeFlow · 2024-01-24T13:22:38Z

@JoanSForgeFlow @LoisRForgeFlow Can you review?

ElmerGForgeFlow

The file detection mechanism has been improved, now adeptly managing PDFs and other file formats through the inclusion of the condition else if (drop_file.name.endsWith(".eml")).
Introducing a reference (this._fileUploaderRef) for the file uploader enhances the structure of the code and facilitates more straightforward access to the uploader component.

It works.

OCA-git-bot · 2024-01-24T15:16:23Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

JordiBForgeFlow · 2024-01-24T16:19:02Z

/ocabot merge nobump

OCA-git-bot · 2024-01-24T16:19:10Z

Sorry @JordiBForgeFlow you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

LoisRForgeFlow

Functional test 👍

etobella · 2024-01-24T16:51:37Z

/ocabot merge nobump

OCA-git-bot · 2024-01-24T16:51:46Z

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-881-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2024-01-24T17:01:27Z

Congratulations, your PR was merged at 233f1b8. Thanks a lot for contributing to OCA. ❤️

JasminSForgeFlow force-pushed the 15.0-mig-mail_drop_target branch 2 times, most recently from 03edf08 to 7462b29 Compare April 4, 2022 09:17

rafaelbn added the needs review label Apr 7, 2022

OCA-git-bot added this to the 15.0 milestone Apr 7, 2022

OCA-git-bot mentioned this pull request Apr 7, 2022

Migration to version 15.0 #789

Open

36 tasks

JasminSForgeFlow force-pushed the 15.0-mig-mail_drop_target branch from 7462b29 to d439613 Compare April 20, 2022 09:01

LoisRForgeFlow force-pushed the 15.0-mig-mail_drop_target branch from d439613 to 9c1160c Compare October 3, 2022 07:57

etobella mentioned this pull request Jan 24, 2023

[IMP] mail_drop_target: Use OWL definition #1046

Merged

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 5, 2023

github-actions bot closed this Mar 12, 2023

etobella reopened this Aug 1, 2023

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 3, 2023

LoisRForgeFlow force-pushed the 15.0-mig-mail_drop_target branch from 9c1160c to d31eceb Compare September 21, 2023 07:32

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 21, 2024

hbrunn and others added 3 commits January 23, 2024 10:47

[ADD] mail_drop_target PoC

8b9b3c8

[MIG] mail_drop_target: Migration to 11.0

e157c32

[ADD] test our code without msgextract

a4fb0cb

Jairo Llopis and others added 10 commits January 23, 2024 10:47

[IMP] pre-commit run -a

d8d74d2

[IMP] Apply pre-commit changes: Resolve conflicts

d8fb365

[IMP] mail_drop_target: black, isort, prettier

e17b6d2

[MIG] mail_drop_target: Migration to 14.0

ab42c45

[UPD] Update mail_drop_target.pot

396a8fb

[UPD] README.rst

c0e3c6d

mail_drop_target 14.0.1.0.1

9697d23

[IMP] mail_drop_target: black, isort, prettier

363d506

[MIG] mail_drop_target: Migration to 15.0

ad5113b

[FIX] Import base64js library to support drag and drop MSG extension …

d1fe8e8

…file

JasminSForgeFlow force-pushed the 15.0-mig-mail_drop_target branch from 5207e38 to ffc81f4 Compare January 23, 2024 05:56

[IMP] mail_drop_target: Fix msg import issue

fa3b61f

JasminSForgeFlow force-pushed the 15.0-mig-mail_drop_target branch from ffc81f4 to fa3b61f Compare January 23, 2024 06:02

[IMP] mail_drop_target: Add other dropped (except .msg and .eml) file…

eb26506

…s as attachment

JordiBForgeFlow approved these changes Jan 24, 2024

View reviewed changes

ElmerGForgeFlow approved these changes Jan 24, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Jan 24, 2024

LoisRForgeFlow approved these changes Jan 24, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jan 24, 2024

OCA-git-bot merged commit 5e3a263 into OCA:15.0 Jan 24, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[15.0][MIG] mail_drop_target #881

[15.0][MIG] mail_drop_target #881

JasminSForgeFlow commented Apr 4, 2022 •

edited by rafaelbn

Loading

oca-clabot commented Apr 4, 2022

rafaelbn commented Apr 7, 2022

etobella commented May 3, 2022

etobella commented May 3, 2022

etobella commented May 3, 2022

ygol commented May 19, 2022

LoisRForgeFlow commented Oct 3, 2022

github-actions bot commented Feb 5, 2023

nguyenminhchien commented Aug 29, 2023

nguyenminhchien commented Aug 30, 2023

LoisRForgeFlow commented Sep 21, 2023 •

edited

Loading

nguyenminhchien commented Sep 22, 2023

github-actions bot commented Jan 21, 2024

JordiBForgeFlow left a comment

JordiBForgeFlow commented Jan 24, 2024

ElmerGForgeFlow left a comment

OCA-git-bot commented Jan 24, 2024

JordiBForgeFlow commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

LoisRForgeFlow left a comment

etobella commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

[15.0][MIG] mail_drop_target #881

[15.0][MIG] mail_drop_target #881

Conversation

JasminSForgeFlow commented Apr 4, 2022 • edited by rafaelbn Loading

oca-clabot commented Apr 4, 2022

rafaelbn commented Apr 7, 2022

etobella commented May 3, 2022

etobella commented May 3, 2022

etobella commented May 3, 2022

ygol commented May 19, 2022

LoisRForgeFlow commented Oct 3, 2022

github-actions bot commented Feb 5, 2023

nguyenminhchien commented Aug 29, 2023

nguyenminhchien commented Aug 30, 2023

LoisRForgeFlow commented Sep 21, 2023 • edited Loading

nguyenminhchien commented Sep 22, 2023

github-actions bot commented Jan 21, 2024

JordiBForgeFlow left a comment

Choose a reason for hiding this comment

JordiBForgeFlow commented Jan 24, 2024

ElmerGForgeFlow left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 24, 2024

JordiBForgeFlow commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

LoisRForgeFlow left a comment

Choose a reason for hiding this comment

etobella commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

OCA-git-bot commented Jan 24, 2024

JasminSForgeFlow commented Apr 4, 2022 •

edited by rafaelbn

Loading

LoisRForgeFlow commented Sep 21, 2023 •

edited

Loading