-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] mail_tracking_mass_mailing: Migration to 15.0 #895
Conversation
Pending merge this PR |
96d7913
to
0e2e818
Compare
[ADD] mail_tracking_mass_mailing ============================== Mail tracking for mass mailing ============================== Links mail statistics objects with mail tracking objects. Installation ============ This addon will be automatically installed when 'mail_tracking' and 'mass_mailing' are both installed Usage ===== From mail statistic object, you can see: - Email tracking state - Email related tracking object - Email related tracking events From mass mailing contact, you can see: - Email score, in order to clean up your lists from bad score emails As a bonus feature, you have a new checkbox 'Avoid resend' in mass mailing, in order to not send twice the same email to the same recipient. This is very useful when you want to resend the mass mailing after changing selection recipients. Notice that recipient selection could be a domain over a model, so result ids could change over the time. With this flag you can send the same email several times but only once to each recipient. OCA Transbot updated translations from Transifex
OCA Transbot updated translations from Transifex
Testing this addon failed if i.e. `mass_mailing_list_dynamic` was installed before. Moving tests to post-install mode fixes integration tests.
* Standard procedure * Adapt tests * New README by fragments [UPD] README.rst
Update translation files [UPD] Update mail_tracking_mass_mailing.pot Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-12.0/social-12.0-mail_tracking_mass_mailing Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_tracking_mass_mailing/ [UPD] README.rst Translated using Weblate (Portuguese) Currently translated at 94.7% (18 of 19 strings) Translation: social-12.0/social-12.0-mail_tracking_mass_mailing Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_tracking_mass_mailing/pt/ Translated using Weblate (Slovenian) Currently translated at 100.0% (19 of 19 strings) Translation: social-12.0/social-12.0-mail_tracking_mass_mailing Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_tracking_mass_mailing/sl/
* Change references to mail_mail_statistics model with mail_trace * Change references to mail.mass_mailing model with mailing.mailing * Change reference to statistics_ids field with mailing_trace_ids * Change reference to send_mail method with action_send_mail * Replace mailing.mailing name for required subject field * fix view reference not_blacklisted with filter_not_email_bl * fix not-stored compute, set value for all the records
If an exception is caught by ir.mail_server.send_email in mail_tracking module, the mail.tracking.email record will appear in error but the related mailing trace would still appear as sent because mail.mail._postprocess_sent_message is called without any failure_type in mail.mail._send in the mail module (as Exception is not raised after being caught in mail_tracking module). Since _postprocess_sent_message method not only sets the mailing.trace state in mass_mailing module but can also delete the mail.mail records in mail module, we need to ensure the mailing.trace is written accordingly to the tracking here, and avoid having the mass_mailing module set a 'sent' status if we had an exception, hence the usage of a context key to ignore possible writes.
8513b5c
to
a6956cf
Compare
a6956cf
to
39d1886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical Review 👍
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@nicomacr Can you fix the tests? |
Superseded by #1022 |
No description provided.