-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG]mass_mailing_list_dynamic: Migration to 15.0 #945
[15.0][MIG]mass_mailing_list_dynamic: Migration to 15.0 #945
Conversation
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Can you please rebase now that the dependency is merged to see if all is correct? |
|
/ocabor migration mass_mailing_list_dynamic |
/ocabot rebase |
* [FIX+IMP] mass_mailing_list_dynamic: tests, icons, filters... * Brand new icon * Added feature of loading an existing filter as criteria * Tests as SavepointCase for optimizing times * Tests in post-install for avoiding errors on res.partner not null constraints when several modules added them. * Updated documentation. * Fix mock in test for not commiting test data. * [FIX] mass_mailing_list_dynamic: Wasn't able to create contacts in fully synced lists Syncing context was being set in the wrong object. Added to test too. * [FIX] mass_mailing_list_dynamic: Allow to write back vals from res.partner Module mass_mailing_partner writes back certain values from partner to mass_mailing_contact. Module should allow that write operation.
- Adds is_synced field to track whether a dynamic list has unsynced changes or not so the user is aware that the definitive number of contacts is yet to be determined. - It fixes an issue that made impossible deleting a res.partner filter when a list had use it to filter contacts. - It also shows only the filters available for the user (shared and belonging to self).
- We change the method to hook on (it wasn't correctly overriden anyway) to ensure the list is resynced even if no recipients are left. For example: we create a dynamic list with a domain expecting it to sync in the first mass_mailing. It wouldn't sync as Odoo dismisses the mailing considering no recipients are left thus it wouldn't get into the `send_mail` method.
[UPD] Update mass_mailing_list_dynamic.pot [UPD] README.rst Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-13.0/social-13.0-mass_mailing_list_dynamic Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mass_mailing_list_dynamic/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-13.0/social-13.0-mass_mailing_list_dynamic Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mass_mailing_list_dynamic/
…ontacts wizard related to dynamic and full sync list [UPD] Update mass_mailing_list_dynamic.pot [UPD] README.rst mass_mailing_list_dynamic 13.0.1.0.1 Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-13.0/social-13.0-mass_mailing_list_dynamic Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mass_mailing_list_dynamic/
Congratulations, PR rebased to 15.0. |
c7d13f4
to
9fc6ecd
Compare
Great, ready to review! 👍 @moduon MT-2479 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
/ocabot migration mass_mailing_list_dynamic |
The migration issue (#789) has been updated to reference the current pull request. |
Congratulations, your PR was merged at 59ed94a. Thanks a lot for contributing to OCA. ❤️ |
Used pull request #825 for mass_mailing_partner dependency