Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG]mass_mailing_list_dynamic: Migration to 15.0 #945

Merged

Conversation

XanderDeJaegere
Copy link

@XanderDeJaegere XanderDeJaegere commented Aug 1, 2022

Used pull request #825 for mass_mailing_partner dependency

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 18, 2022
@pedrobaeza
Copy link
Member

Can you please rebase now that the dependency is merged to see if all is correct?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 25, 2022
@gregory-moka
Copy link

Can you please rebase now that the dependency is merged to see if all is correct?

@XanderDeJaegere 😃

@rafaelbn rafaelbn added this to the 15.0 milestone Mar 4, 2023
@rafaelbn
Copy link
Member

rafaelbn commented Mar 4, 2023

/ocabor migration mass_mailing_list_dynamic

@rafaelbn
Copy link
Member

rafaelbn commented Mar 4, 2023

/ocabot rebase

@XanderDeJaegere

yajo and others added 17 commits March 4, 2023 11:09
* [FIX+IMP] mass_mailing_list_dynamic: tests, icons, filters...

* Brand new icon
* Added feature of loading an existing filter as criteria
* Tests as SavepointCase for optimizing times
* Tests in post-install for avoiding errors on res.partner not null constraints
  when several modules added them.
* Updated documentation.
* Fix mock in test for not commiting test data.

* [FIX] mass_mailing_list_dynamic: Wasn't able to create contacts in fully synced lists

Syncing context was being set in the wrong object. Added to test too.

* [FIX] mass_mailing_list_dynamic: Allow to write back vals from res.partner

Module mass_mailing_partner writes back certain values from partner to
mass_mailing_contact. Module should allow that write operation.
- Adds is_synced field to track whether a dynamic list has unsynced
changes or not so the user is aware that the definitive number of
contacts is yet to be determined.
- It fixes an issue that made impossible deleting a res.partner filter
when a list had use it to filter contacts.
- It also shows only the filters available for the user (shared and
belonging to self).
- We change the method to hook on (it wasn't correctly overriden anyway)
to ensure the list is resynced even if no recipients are left. For
example: we create a dynamic list with a domain expecting it to sync in
the first mass_mailing. It wouldn't sync as Odoo dismisses the mailing
considering no recipients are left thus it wouldn't get into the
`send_mail` method.
[UPD] Update mass_mailing_list_dynamic.pot

[UPD] README.rst

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-13.0/social-13.0-mass_mailing_list_dynamic
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mass_mailing_list_dynamic/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-13.0/social-13.0-mass_mailing_list_dynamic
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mass_mailing_list_dynamic/
…ontacts wizard related to dynamic and full sync list

[UPD] Update mass_mailing_list_dynamic.pot

[UPD] README.rst

mass_mailing_list_dynamic 13.0.1.0.1

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-13.0/social-13.0-mass_mailing_list_dynamic
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-mass_mailing_list_dynamic/
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 15.0.

@OCA-git-bot OCA-git-bot force-pushed the 15.0-mig-mass_mailing_list_dynamic branch from c7d13f4 to 9fc6ecd Compare March 4, 2023 11:09
@rafaelbn
Copy link
Member

rafaelbn commented Mar 4, 2023

Great, ready to review! 👍

@moduon MT-2479

Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you

Copy link

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-945-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza
Copy link
Member

/ocabot migration mass_mailing_list_dynamic

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 7, 2023
36 tasks
@OCA-git-bot
Copy link
Contributor

The migration issue (#789) has been updated to reference the current pull request.
however, a previous pull request was referenced : #1087.
Perhaps you should check that there is no duplicate work.
CC : @bizzappdev

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 59ed94a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.