Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] mail_layout_force #973

Merged
merged 6 commits into from
Feb 15, 2023
Merged

[15.0][MIG] mail_layout_force #973

merged 6 commits into from
Feb 15, 2023

Conversation

yostashiro
Copy link
Member

@yostashiro yostashiro commented Oct 2, 2022 •
edited
Loading

Standard migration.

@qrtl

@ivantodorovich
Copy link
Contributor

Thanks a lot!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @ivantodorovich you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@ivantodorovich
Copy link
Contributor

Weird, I'm not recognized as maintainer

@yostashiro
Copy link
Member Author

@ivantodorovich Would it help if I add you as the maintainer in this PR? Thanks for the module btw!

@ivantodorovich
Copy link
Contributor

Thank you for migrating it ❤️

Would it help if I add you as the maintainer in this PR?

The strange thing is that I'm already a maintainer. @OCA-git-bot is ignoring me.
Anyway, let's just wait for someone with merging rights to show up

Abranes
Abranes approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@Abranes Abranes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Abranes
Copy link
Member

Abranes commented Feb 9, 2023

@yostashiro can you do a rebase from 15.0?

@yostashiro
Copy link
Member Author

@yostashiro can you do a rebase from 15.0?

@Abranes Done. :D

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Abranes Abranes mentioned this pull request Feb 13, 2023
Closed
@Abranes
Copy link
Member

Abranes commented Feb 15, 2023

ping @OCA/social-maintainers

@rafaelbn
Copy link
Member

/ocabot migration mail_layout_force

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Feb 15, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 15, 2023
Open
36 tasks
rafaelbn
rafaelbn approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-973-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 089f7b5 into OCA:15.0 Feb 15, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 27a1124. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivantodorovich ivantodorovich ivantodorovich approved these changes

@Abranes Abranes Abranes approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yostashiro @ivantodorovich @OCA-git-bot @Abranes @rafaelbn @oca-travis