[16.0][ADD] stock_move_actual_date #1711

AungKoKoLin1997 · 2023-05-18T09:30:19Z

This module adds actual date in picking and scrap and pass the value to stock move, stock move line and accounting date of SVL's journal entry.

When a user makes the transfer for the products with "real time" inventory valuation, effective date in transfer couldn't be selected.
And Accounting date for stock valuation journal entry will be the same with effective date.
So, for the users who want to specify each transfer's actual accounting date needs to reset to draft manually and
change accounting date. This module intends to get rid of this inconvenience by adding actual date in transfer and scrap and then pass to journal entry.

@qrtl 4850

rousseldenis · 2024-02-15T09:17:39Z

stock_picking_accounting_date/models/stock_move.py

+        # inventory adjustment
+        force_period_date = self._context.get("force_period_date")
+        if force_period_date:
+            self.write({"accounting_date": force_period_date})


@AungKoKoLin1997 Never doing a write in a compute !

yostashiro · 2024-02-16T14:42:35Z

stock_picking_accounting_date/tests/test_stock_picking_accounting_date.py

+        super(TestStockValuation, self).setUp()
+
+    def test_stock_picking_accounting_date(self):
+        self.product1.categ_id.property_cost_method = "fifo"


Suggested change

self.product1.categ_id.property_cost_method = "fifo"

I guess this assignment doesn't affect the test. Can we ensure that the valuation is real_time instead?

yostashiro

@AungKoKoLin1997 Can you please add another test to ensure that accounting date set in inventory adjustment is not interfered by this module?

yostashiro · 2024-03-19T05:31:14Z

stock_picking_accounting_date/tests/test_stock_picking_accounting_date.py

+        accounting_date = date.today() + timedelta(days=3)
+        inventory_quant.accounting_date = accounting_date
+        inventory_quant.with_context(
+            skip_exceeded_discrepancy=True


I don't think we should be doing this as this context doesn't belong to a module in the dependency chain. It should ideally be handled by adjusting the stock_inventory_discrepancy module or by setting rogue modules.

rousseldenis · 2024-03-19T10:00:38Z

stock_picking_accounting_date/models/stock_move.py

+        store=True,
+    )
+
+    @api.depends("date", "accounting_date")


@AungKoKoLin1997 Shouldn't it be 'picking_id.accounting_date' ???

rousseldenis · 2024-03-19T10:01:15Z

stock_picking_accounting_date/models/stock_move.py

+    def _compute_accounting_date(self):
+        # 'force_period_date' context is assigned when user sets accounting date in
+        # inventory adjustment
+        force_period_date = self._context.get("force_period_date")


I don't really like computed stored fields based on context values....

yostashiro · 2024-03-20T01:03:36Z

stock_picking_accounting_date/models/stock_move.py

+        # 'force_period_date' context is assigned when user sets accounting date in
+        # inventory adjustment
+        force_period_date = self._context.get("force_period_date")
+        if force_period_date:
+            for rec in self:
+                rec.accounting_date = force_period_date
+        else:
+            for rec in self:
+                if rec.picking_id.accounting_date:
+                    rec.accounting_date = rec.picking_id.accounting_date
+                    continue
+                rec.accounting_date = fields.Datetime.context_timestamp(self, rec.date)


Let's remove the condition based on the context here, as @rousseldenis suggests.

Suggested change

# 'force_period_date' context is assigned when user sets accounting date in

# inventory adjustment

force_period_date = self._context.get("force_period_date")

if force_period_date:

for rec in self:

rec.accounting_date = force_period_date

else:

for rec in self:

if rec.picking_id.accounting_date:

rec.accounting_date = rec.picking_id.accounting_date

continue

rec.accounting_date = fields.Datetime.context_timestamp(self, rec.date)

for rec in self:

if rec.picking_id.accounting_date:

rec.accounting_date = rec.picking_id.accounting_date

continue

rec.accounting_date = fields.Datetime.context_timestamp(self, rec.date)

stock_picking_accounting_date/models/stock_move.py

+        am_vals = super(StockMove, self)._prepare_account_move_vals(
+            credit_account_id,
+            debit_account_id,
+            journal_id,
+            qty,
+            description,
+            svl_id,
+            cost,
+        )


yostashiro · 2024-03-20T02:23:02Z

stock_picking_accounting_date/models/stock_move.py

+        # 'force_period_date' context is assigned when user sets accounting date in
+        # inventory adjustment


Oops, missed these lines.

Suggested change

# 'force_period_date' context is assigned when user sets accounting date in

# inventory adjustment

yostashiro · 2024-09-24T02:06:20Z

stock_picking_actual_date/models/stock_move.py

+        for vals in vals_list:
+            if vals.get("actual_date"):
+                self = self.with_context(actual_date=vals["actual_date"])
+        return super().create(vals_list)


A bit tedious but somethings like this?

Suggested change

for vals in vals_list:

if vals.get("actual_date"):

self = self.with_context(actual_date=vals["actual_date"])

return super().create(vals_list)

moves = self.env["stock.move"]

vals_list_with_actual_date = []

vals_list_without_actual_date = []

for vals in vals_list:

if vals.get("actual_date"):

vals_list_with_actual_date.append(vals)

else:

vals_list_without_actual_date.append(vals)

for vals in vals_list_with_actual_date:

move = super().with_context(actual_date=vals["actual_date"]).create(vals)

moves += move

if vals_list_without_actual_date:

moves += super().create(vals_list_without_actual_date)

return moves

yostashiro

@AungKoKoLin1997 My suggestion should work as far as I've checked. Am I missing something?

yostashiro · 2024-09-24T07:48:23Z

stock_picking_actual_date/models/stock_scrap.py

+    def _prepare_move_values(self):
+        vals = super()._prepare_move_values()
+        if self.actual_date:
+            vals["actual_date"] = self.actual_date
+        return vals
+


Suggested change

def _prepare_move_values(self):

vals = super()._prepare_move_values()

if self.actual_date:

vals["actual_date"] = self.actual_date

return vals

yostashiro · 2024-09-24T07:50:41Z

stock_picking_actual_date/models/stock_scrap.py

+                if not account_moves:
+                    continue
+                account_moves._update_accounting_date()
+        return res


Suggested change

return res

return res

def do_scrap(self):

for scrap in self:

scrap = scrap.with_context(actual_date=scrap.actual_date)

super(StockScrap, scrap).do_scrap()

return True

yostashiro · 2024-09-24T07:51:23Z

stock_picking_actual_date/models/stock_move.py

+    @api.model_create_multi
+    def create(self, vals_list):
+        # Pass the 'actual_date' as context to use in _compute_actual_date() when
+        # the stock move is created for the scrap.
+        # Since there is no 'scrap_ids' value at the time of creation of the move,
+        # the scrap and move are linked only after the move is done as per the design
+        # of the 'do_scrap()' method.
+        for vals in vals_list:
+            if vals.get("actual_date") and vals.get("scrapped"):
+                # Expect only one stock move in vals_list if it is from scrap.
+                self = self.with_context(actual_date=vals["actual_date"])
+                return super(StockMove, self).create([vals])
+        return super().create(vals_list)
+


Suggested change

@api.model_create_multi

def create(self, vals_list):

# Pass the 'actual_date' as context to use in _compute_actual_date() when

# the stock move is created for the scrap.

# Since there is no 'scrap_ids' value at the time of creation of the move,

# the scrap and move are linked only after the move is done as per the design

# of the 'do_scrap()' method.

for vals in vals_list:

if vals.get("actual_date") and vals.get("scrapped"):

# Expect only one stock move in vals_list if it is from scrap.

self = self.with_context(actual_date=vals["actual_date"])

return super(StockMove, self).create([vals])

return super().create(vals_list)

AungKoKoLin1997 · 2024-09-24T15:16:00Z

My suggestion should work as far as I've checked. Am I missing something?

@yostashiro You are right. It seems like I missed something. My apologies.

yostashiro

@AungKoKoLin1997 Can you please increase the test coverage.

I'm also thinking that the name stock_move_actual_date may be more appropriate. What do you think?

yostashiro · 2024-09-25T00:32:40Z

stock_picking_actual_date/tests/test_stock_picking_actual_date.py

+
+class TestStockValuation(TestStockValuation):
+    def setUp(self):
+        super(TestStockValuation, self).setUp()


We should isolate our tests.

yostashiro · 2024-09-26T02:07:23Z

stock_move_actual_date/tests/test_stock_move_actual_date.py

+            date(2024, 8, 11),
+        )
+
+        # Test inventory adjustment with actual date


Put this into a dedicated test method to make it easier to follow.

yostashiro · 2024-09-26T02:10:14Z

stock_move_actual_date/tests/test_stock_move_actual_date.py

+        )
+        cls.supplier_location = cls.env.ref("stock.stock_location_suppliers")
+        cls.stock_location = cls.env.ref("stock.stock_location_stock")
+        cls.env.user.tz = "Asia/Tokyo"


For clarity of the test scenario, it would be better to put this inside test_stock_move_without_actual_date_from_picking_or_scrap() which is the only test this setting matters.

yostashiro · 2024-09-26T08:23:41Z

stock_move_actual_date/tests/test_stock_move_actual_date.py

+        _, _ = self.create_picking()
+        inventory_quant = self.env["stock.quant"].search(
+            [
+                ("location_id", "=", self.stock_location.id),
+                ("product_id", "=", self.product_1.id),
+            ]
+        )
+        inventory_quant.inventory_quantity = 20.0
+        inventory_quant.accounting_date = date(2024, 7, 1)


Why don't we just directly create a quant?

There was no reason. Your suggestion is more clear. I updated.

yostashiro · 2024-09-26T09:32:26Z

stock_move_actual_date/tests/test_stock_move_actual_date.py

+        self.assertEqual(
+            move.stock_valuation_layer_ids.account_move_id.date, date(2024, 9, 1)
+        )


move.stock_valuation_layer_ids could involve adjustment layers and therefore is not desirable to be relied upon.

Suggested change

self.assertEqual(

move.stock_valuation_layer_ids.account_move_id.date, date(2024, 9, 1)

)

self.assertEqual(move.account_move_ids.date, date(2024, 9, 1))

Please apply the same to the rest.

yostashiro

Code review.

@AungKoKoLin1997 Please squash commits once it's good to do so.

kanda999 · 2024-10-08T04:12:51Z

stock_move_actual_date/hooks.py

+# Copyright 2024 Quartile (https://www.quartile.co)
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
+
+from openupgradelib import openupgrade


Suggested change

from openupgradelib import openupgrade

from odoo.tools.sql import column_exists

We don't need openupgradelib?

Thanks! It is valid.

This module adds actual date in picking and scrap and pass the value to stock move, stock move line and accounting date of SVL's journal entry. When a user makes the transfer for the products with "real time" inventory valuation, effective date in transfer couldn't be selected. And Accounting date for stock valuation journal entry will be the same with effective date. So, for the users who want to specify each transfer's actual accounting date needs to reset to draft manually and change accounting date. This module intends to get rid of this inconvenience by adding actual date in transfer and scrap and then pass to journal entry.

AungKoKoLin1997 mentioned this pull request May 18, 2023

[16.0][ADD] stock_picking_accounting_date OCA/account-invoicing#1460

Closed

AungKoKoLin1997 mentioned this pull request Jun 9, 2023

[16.0][UPD] dotfiles qrtl/axls-oca#63

Merged

yostashiro mentioned this pull request Jul 1, 2023

[Add] stock_picking_account_date: new module that add accounting date… OCA/stock-logistics-workflow#1322

Closed

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch 3 times, most recently from 26fa304 to ebf73d2 Compare August 24, 2023 09:56

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from ebf73d2 to 3379d16 Compare October 18, 2023 07:27

AungKoKoLin1997 mentioned this pull request Oct 18, 2023

[16.0][ADD] stock_valuation_layer_accounting_date #1868

Closed

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 3379d16 to 31121ad Compare October 27, 2023 04:24

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 31121ad to cba1f84 Compare November 13, 2023 01:56

rinaldifirdaus force-pushed the 16.0-add-stock_picking_accounting_date branch from af39fdd to 69cdb19 Compare December 29, 2023 06:36

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 69cdb19 to 86a8263 Compare February 15, 2024 04:25

rousseldenis added the needs review label Feb 15, 2024

rousseldenis added this to the 16.0 milestone Feb 15, 2024

rousseldenis reviewed Feb 15, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 86a8263 to 825b3d1 Compare February 16, 2024 01:27

yostashiro reviewed Feb 16, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch 3 times, most recently from 83171c6 to 2908226 Compare March 15, 2024 03:47

yostashiro reviewed Mar 15, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch 4 times, most recently from 1c84542 to 9332b0b Compare March 19, 2024 04:29

yostashiro reviewed Mar 19, 2024

View reviewed changes

rousseldenis reviewed Mar 19, 2024

View reviewed changes

yostashiro suggested changes Mar 20, 2024

View reviewed changes

yostashiro reviewed Mar 20, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 9be2cd9 to 4ec796a Compare September 23, 2024 14:29

yostashiro reviewed Sep 24, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 4ec796a to 61c1128 Compare September 24, 2024 06:03

yostashiro reviewed Sep 24, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 61c1128 to 5dd805e Compare September 24, 2024 15:08

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 5dd805e to 257f1ba Compare September 24, 2024 15:16

yostashiro reviewed Sep 25, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 257f1ba to 8c33664 Compare September 25, 2024 02:22

AungKoKoLin1997 changed the title ~~[16.0][ADD] stock_picking_actual_date~~ [16.0][ADD] stock_move_actual_date Sep 25, 2024

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch 3 times, most recently from fb02ab9 to b457c89 Compare September 25, 2024 15:06

AungKoKoLin1997 requested a review from yostashiro September 25, 2024 15:08

yostashiro reviewed Sep 26, 2024

View reviewed changes

AungKoKoLin1997 requested a review from yostashiro September 26, 2024 07:08

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from adc1c9e to 1c77025 Compare September 26, 2024 07:13

yostashiro reviewed Sep 26, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 1c77025 to 88ad942 Compare September 26, 2024 09:02

yostashiro reviewed Sep 26, 2024

View reviewed changes

AungKoKoLin1997 force-pushed the 16.0-add-stock_picking_accounting_date branch from 88ad942 to 9f04df4 Compare September 26, 2024 10:19

AungKoKoLin1997 requested a review from yostashiro September 26, 2024 10:21

yostashiro approved these changes Sep 26, 2024

View reviewed changes

kanda999 reviewed Oct 8, 2024

View reviewed changes

AungKoKoLin1997 requested a review from kanda999 October 9, 2024 02:28

AungKoKoLin1997 mentioned this pull request Nov 15, 2024

[17.0][MIG] Migration of module stock_picking_accounting_date #2196

Open

nobuQuartile force-pushed the 16.0-add-stock_picking_accounting_date branch 2 times, most recently from cd2bf04 to 52b4338 Compare December 19, 2024 07:14

nobuQuartile force-pushed the 16.0-add-stock_picking_accounting_date branch from 52b4338 to b0867ae Compare December 19, 2024 07:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] stock_move_actual_date #1711

[16.0][ADD] stock_move_actual_date #1711

AungKoKoLin1997 commented May 18, 2023 •

edited

Loading

rousseldenis Feb 15, 2024

yostashiro Feb 16, 2024

yostashiro left a comment

yostashiro Mar 19, 2024 •

edited

Loading

rousseldenis Mar 19, 2024

rousseldenis Mar 19, 2024

yostashiro Mar 20, 2024

This comment was marked as outdated.

yostashiro Mar 20, 2024

yostashiro Sep 24, 2024 •

edited

Loading

yostashiro left a comment

yostashiro Sep 24, 2024

yostashiro Sep 24, 2024

yostashiro Sep 24, 2024

AungKoKoLin1997 commented Sep 24, 2024

yostashiro left a comment

yostashiro Sep 25, 2024

yostashiro Sep 26, 2024

yostashiro Sep 26, 2024

yostashiro Sep 26, 2024

AungKoKoLin1997 Sep 26, 2024

yostashiro Sep 26, 2024

yostashiro left a comment •

edited

Loading

kanda999 Oct 8, 2024

AungKoKoLin1997 Oct 9, 2024

		# 'force_period_date' context is assigned when user sets accounting date in
		# inventory adjustment

-        for vals in vals_list:
-            if vals.get("actual_date"):
-                self = self.with_context(actual_date=vals["actual_date"])
-        return super().create(vals_list)
+    moves = self.env["stock.move"]
+    vals_list_with_actual_date = []
+    vals_list_without_actual_date = []
+    for vals in vals_list:
+        if vals.get("actual_date"):
+            vals_list_with_actual_date.append(vals)
+        else:
+            vals_list_without_actual_date.append(vals)
+    for vals in vals_list_with_actual_date:
+        move = super().with_context(actual_date=vals["actual_date"]).create(vals)
+        moves += move
+    if vals_list_without_actual_date:
+        moves += super().create(vals_list_without_actual_date)
+    return moves

-        return res
+        return res
+    def do_scrap(self):
+        for scrap in self:
+            scrap = scrap.with_context(actual_date=scrap.actual_date)
+            super(StockScrap, scrap).do_scrap()
+        return True

	from openupgradelib import openupgrade
	from odoo.tools.sql import column_exists

[16.0][ADD] stock_move_actual_date #1711

Are you sure you want to change the base?

[16.0][ADD] stock_move_actual_date #1711

Conversation

AungKoKoLin1997 commented May 18, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

yostashiro Mar 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as outdated.

Choose a reason for hiding this comment

yostashiro Sep 24, 2024 • edited Loading

Choose a reason for hiding this comment

yostashiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AungKoKoLin1997 commented Sep 24, 2024

yostashiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yostashiro left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AungKoKoLin1997 commented May 18, 2023 •

edited

Loading

yostashiro Mar 19, 2024 •

edited

Loading

yostashiro Sep 24, 2024 •

edited

Loading

yostashiro left a comment •

edited

Loading