Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][ADD]stock_package_autoload: new module #2027

Closed

Conversation

PicchiSeba
Copy link

This module allows to automatically add the content of a package to the transfer lines

@PicchiSeba
Copy link
Author

Please let me know if this could be an interesting addition to the repo and if so, if tests are needed

@PicchiSeba PicchiSeba force-pushed the 14.0-stock_package_autoload-new-module branch from 119a0ea to 1ce65a2 Compare May 10, 2024 15:06
@PicchiSeba PicchiSeba changed the title [14.0][IMP]stock_package_autoload: new module [14.0][ADD]stock_package_autoload: new module May 10, 2024
@PicchiSeba PicchiSeba force-pushed the 14.0-stock_package_autoload-new-module branch from 1ce65a2 to 14e6857 Compare May 13, 2024 08:57
@PicchiSeba
Copy link
Author

I added some tests

Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor fix, otherwise LGTM

stock_package_autoload/models/stock_move.py Show resolved Hide resolved
@PicchiSeba PicchiSeba force-pushed the 14.0-stock_package_autoload-new-module branch from 14e6857 to adc6024 Compare May 13, 2024 09:02
This module allows to automatically add the content of a package to the transfer lines
@PicchiSeba PicchiSeba force-pushed the 14.0-stock_package_autoload-new-module branch from adc6024 to 8ff4652 Compare May 13, 2024 09:26
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 20, 2024
@github-actions github-actions bot closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants