Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] account_move_line_stock_info #229

Merged
merged 4 commits into from
Dec 20, 2016

Conversation

JordiBForgeFlow
Copy link
Member

Account Move Line Stock Move

This module adds the stock move to the account move lines that it generates.

Usage

  • The stock manager can check the journal items generated by a stock
    move, by accessing to the picking, then clicking on one of the moves, to
    display the list of journal items.

  • An accounting user or manager can review the details of a move that is
    associated to a journal item that she/he is checking.

@JordiBForgeFlow
Copy link
Member Author

cc @andhit-r you might as well me interested in this one.
cc @eficent: your review is welcome!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments in the code.

[self.group_stock_user,
self.group_account_invoice],
self.company)
self.account_invoice = self._create_user('account_invoice',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like 'accountant' or 'account_user' will be more descriptive, do you agree?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

account_invoice is a defined group in odoo.

for move in picking_in.move_lines:
self.assertEqual(len(move.account_move_line_ids), 2)
for aml in move.account_move_line_ids:
self.assertEqual(aml.name, move.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This for is duplicated, maybe it should be erased.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, fixed. Thanks

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as @lreficent

Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

],
"author": "Eficent,"
"Odoo Community Association (OCA)",
"website": "https://github.com/OCA/stock-logistics-warehouse",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using Eficent website?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the end it's more practical that people should get access to the OCA repo. We're not maintaing any page in our website that better describes this module.

Copy link
Member

@andhit-r andhit-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's harder for accountant to see the stock move. But this due original Odoo view. The only way accountant can access stock move info is via Journal Items menu. Click journal item data so odoo will enter editable mode. And then switch to form view using right-top view switcher button.

A solution for above problem is a nice to have. But overall 👍

'views/account_move_line_view.xml',
'views/stock_move_view.xml',
],
"images": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove empty dictionary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the stock move to the account move line is needed to ensure traceability. It's not necessary to make this field super visible in the journal entries/items.

Another module should implement an "Inventory Audit Report', such as https://help.sap.com/saphelp_sbo882/helpdata/en/45/22e90a73c80108e10000000a114a6b/content.htm

@JordiBForgeFlow JordiBForgeFlow merged commit 59dca55 into OCA:8.0 Dec 20, 2016
LoisRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Dec 20, 2016
* [ADD] account_move_line_stock_info
LoisRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Mar 16, 2017
* [ADD] account_move_line_stock_info
LoisRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request May 30, 2017
* [ADD] account_move_line_stock_info
MiquelRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Aug 30, 2018
* [ADD] account_move_line_stock_info
MiquelRForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Sep 27, 2018
* [ADD] account_move_line_stock_info
bjeficent pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Nov 30, 2018
* [ADD] account_move_line_stock_info
ps-tubtim pushed a commit to ecosoft-odoo/stock-logistics-warehouse that referenced this pull request Dec 17, 2019
* [ADD] account_move_line_stock_info
@LoisRForgeFlow LoisRForgeFlow deleted the 8.0-account_move_line_stock_info branch December 17, 2019 09:10
CarlosRoca13 pushed a commit to Tecnativa/stock-logistics-warehouse that referenced this pull request Aug 16, 2021
* [ADD] account_move_line_stock_info
JoanMForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Oct 15, 2021
* [ADD] account_move_line_stock_info
JoanMForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Oct 28, 2021
* [ADD] account_move_line_stock_info
BT-atornero pushed a commit to BT-atornero/stock-logistics-warehouse that referenced this pull request Jan 20, 2023
* [ADD] account_move_line_stock_info
BT-nfrancisco pushed a commit to BT-nfrancisco/stock-logistics-warehouse that referenced this pull request Feb 16, 2023
* [ADD] account_move_line_stock_info
BT-nfrancisco pushed a commit to BT-nfrancisco/stock-logistics-warehouse that referenced this pull request Feb 17, 2023
* [ADD] account_move_line_stock_info
CarlosVForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Mar 21, 2024
* [ADD] account_move_line_stock_info
StefanRijnhart pushed a commit to StefanRijnhart/stock-logistics-warehouse that referenced this pull request Sep 23, 2024
* [ADD] account_move_line_stock_info
alan196 pushed a commit to Jarsa/stock-logistics-warehouse that referenced this pull request Nov 15, 2024
* [ADD] account_move_line_stock_info
JasminSForgeFlow pushed a commit to ForgeFlow/stock-logistics-warehouse that referenced this pull request Dec 16, 2024
* [ADD] account_move_line_stock_info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants