-
-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] account_move_line_stock_info #229
[8.0] account_move_line_stock_info #229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments in the code.
[self.group_stock_user, | ||
self.group_account_invoice], | ||
self.company) | ||
self.account_invoice = self._create_user('account_invoice', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe something like 'accountant' or 'account_user' will be more descriptive, do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
account_invoice is a defined group in odoo.
for move in picking_in.move_lines: | ||
self.assertEqual(len(move.account_move_line_ids), 2) | ||
for aml in move.account_move_line_ids: | ||
self.assertEqual(aml.name, move.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This for is duplicated, maybe it should be erased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, fixed. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as @lreficent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
], | ||
"author": "Eficent," | ||
"Odoo Community Association (OCA)", | ||
"website": "https://github.com/OCA/stock-logistics-warehouse", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using Eficent website?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end it's more practical that people should get access to the OCA repo. We're not maintaing any page in our website that better describes this module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's harder for accountant to see the stock move. But this due original Odoo view. The only way accountant can access stock move info is via Journal Items menu. Click journal item data so odoo will enter editable mode. And then switch to form view using right-top view switcher button.
A solution for above problem is a nice to have. But overall 👍
'views/account_move_line_view.xml', | ||
'views/stock_move_view.xml', | ||
], | ||
"images": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove empty dictionary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the stock move to the account move line is needed to ensure traceability. It's not necessary to make this field super visible in the journal entries/items.
Another module should implement an "Inventory Audit Report', such as https://help.sap.com/saphelp_sbo882/helpdata/en/45/22e90a73c80108e10000000a114a6b/content.htm
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
* [ADD] account_move_line_stock_info
Account Move Line Stock Move
This module adds the stock move to the account move lines that it generates.
Usage
The stock manager can check the journal items generated by a stock
move, by accessing to the picking, then clicking on one of the moves, to
display the list of journal items.
An accounting user or manager can review the details of a move that is
associated to a journal item that she/he is checking.