Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] membership_extension: Don't return early #163

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[15.0][FIX] membership_extension: Don't return early #163

merged 1 commit into from
Oct 17, 2024

Conversation

pedrobaeza
Copy link
Member

@pedrobaeza pedrobaeza commented Jan 8, 2024 •
edited
Loading

Follow-up of #159 after not getting answer

Don't return before consuming whole recordset.

@Tecnativa

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jan 8, 2024
@pedrobaeza pedrobaeza force-pushed the 15.0-fix-membership_extension-compute_state branch from 1bc13cc to 27ea112 Compare January 8, 2024 18:04
@pedrobaeza pedrobaeza changed the title [15.0][FIX] membership_extension: Don't return early + remove condition [15.0][FIX] membership_extension: Don't return early Jan 8, 2024
@pedrobaeza pedrobaeza mentioned this pull request Jan 8, 2024
Closed
@pedrobaeza pedrobaeza force-pushed the 15.0-fix-membership_extension-compute_state branch from 27ea112 to a782fea Compare January 8, 2024 18:07
@AlbertCabedo
Copy link

+1

rafaelbn
rafaelbn approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Apr 23, 2024
@OCA-git-bot
Merge PR #163 into 15.0
1678be6 
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

1 similar comment
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-163-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rafaelbn
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force Tecnativa tmp-pr-163:15.0-fix-membership_extension-compute_state failed with output:

remote: Permission to Tecnativa/vertical-association.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/Tecnativa/vertical-association/': The requested URL returned error: 403

@rafaelbn
Copy link
Member

@pedrobaeza you can merge this FIX but test are failing

@pedrobaeza
Copy link
Member Author

Tests failing is due to other module (and main branch is also red). It's in my backlog to fix the branch, but not able to do it for now.

@gaikaz
Copy link
Member

gaikaz commented May 1, 2024

I was about to create a PR for the exact fix on 16.0
Could we get this merged and forward-ported?

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 1, 2024
@pedrobaeza pedrobaeza removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 2, 2024
hhgabelgaard
hhgabelgaard approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@hhgabelgaard hhgabelgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works

@pedrobaeza pedrobaeza force-pushed the 15.0-fix-membership_extension-compute_state branch from a782fea to eade914 Compare October 17, 2024 18:26
@pedrobaeza
[FIX] membership_extension: Don't return early
1880c48 
Don't return before consuming whole recordset.
@pedrobaeza pedrobaeza force-pushed the 15.0-fix-membership_extension-compute_state branch from eade914 to 1880c48 Compare October 17, 2024 18:46
@pedrobaeza
Copy link
Member Author

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-163-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 80bb237 into OCA:15.0 Oct 17, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0f73d50. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 15.0-fix-membership_extension-compute_state branch October 17, 2024 18:59
This was referenced Oct 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaikaz gaikaz gaikaz approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@hhgabelgaard hhgabelgaard hhgabelgaard approved these changes

@chienandalu chienandalu chienandalu approved these changes

@sbejaoui sbejaoui Awaiting requested review from sbejaoui

Assignees
No one assigned
Labels
approved merged 🎉 needs review
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
7 participants
@pedrobaeza @AlbertCabedo @OCA-git-bot @rafaelbn @gaikaz @chienandalu @hhgabelgaard