[FIX] webservice: WARNING message in logs #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of a compute method on `oauth2_flow` when this field is touched by the server environment mixin causes it to be defined twice as computed, with differents settings, and this ultimately causes a warning message in the logs: ``` WARNING odoo odoo.modules.registry: webservice.backend: inconsistent 'compute_sudo' for computed fields: protocol, url, auth_type, username, password, api_key, api_key_header, oauth2_flow, oauth2_clientid, oauth2_client_secret, oauth2_token_url, oauth2_authorization_url, oauth2_audience, oauth2_scope, content_type ``` We fix this by using an old fashioned onchange declaration on the `auth_type` field.
|
Hi @etobella, |
StephaneMangin
approved these changes
Jul 9, 2024
henrybackman
reviewed
Jul 9, 2024
|
@gurneyalex I've opened a new PR to speed up the fix: #63 @grindtildeath @simahawk @henrybackman @StephaneMangin would you mind reviewing the new PR? |
rvalyi
reviewed
Sep 7, 2024
| def _compute_server_env(self): | ||
| # OVERRIDE: reset ``oauth2_flow`` when ``auth_type`` is not "oauth2", even if | ||
| # defined otherwise in server env vars | ||
| res = super(WebserviceBackend, self)._compute_server_env() |
There was a problem hiding this comment.
I think it should be just super()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of a compute method on
oauth2_flowwhen this field is touched by the server environment mixin causes it to be defined twice as computed, with differents settings, and this ultimately causes a warning message in the logs:We fix this by using an old fashioned onchange declaration on the
auth_typefield.