-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] webservice: allow to return response object on http calls #48
[16.0][IMP] webservice: allow to return response object on http calls #48
Conversation
Hi @etobella, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review 👍
This PR has the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need a field for this?
Can't we have a param to achieve the same?
Maybe you can explain a bit more about your use case?
@simahawk you mean to pass it as a parameter in the kwargs of the The use case is basically that I need to extract some information of the headers of the response, so I need the result of the |
Yes, eg:
But it means that you don't do this programmatically and you are calling |
@simahawk yes, I am calling backend.call directly, so I should be able to pass it as a parameter. I will propose the change. |
6216d0e
to
553dcf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some reference about content_only kwarg in the README would be nice :)
553dcf5
to
85cf5c0
Compare
@simahawk could we get this one merged? :) |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
@simahawk could we get this one merged? |
/ocabot merge minor |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 9bb851b. Thanks a lot for contributing to OCA. ❤️ |
you may need to use information on the headers of the response