Ignore topologyupdater in nodefeaturediscovery manifests #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be some weirdness around the CRD for the NodeFeatureDiscovery operator: you need to set the `topologyUpdater` attribute, but at least on nerc-ocp-test, when you fetch the resource, you see `toplogyupdater` (note capitalization difference). This causes argocd to think the app is out of sync. This commit instructs argocd to ignore either of these names in the resource.
computate
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be some weirdness around the CRD for the
NodeFeatureDiscovery operator: you need to set the
topologyUpdaterattribute, but at least on nerc-ocp-test, when you fetch the resource, you
see
toplogyupdater(note capitalization difference). This causes argocdto think the app is out of sync.
This commit instructs argocd to ignore either of these names in the
resource.