Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output_file_grp not set to ocrd-tool.json default for processors #274

Closed
kba opened this issue Aug 8, 2019 · 4 comments · Fixed by #586
Closed

output_file_grp not set to ocrd-tool.json default for processors #274

kba opened this issue Aug 8, 2019 · 4 comments · Fixed by #586
Assignees

Comments

@kba
Copy link
Member

kba commented Aug 8, 2019

e.g.

{
  output_file_grp: "OCR-D-IMG-BIN",
}

but in processor's process method:

print(self.output_file_grp)

prints OUTPUT not OCR-D-IMG-BIN.

@kba kba self-assigned this Aug 8, 2019
@kba
Copy link
Member Author

kba commented Aug 8, 2019

@crater2150 reports the same problem for input_file_grp

@kba
Copy link
Member Author

kba commented Sep 6, 2019

Related https://github.com/OCR-D/ocrd_tesserocr/pull/75/files#r321639953

But I agree with you all these errors should be reported properly and as early as possible. So either the Processor base class or process_cli / ocrd_cli_wrap_processor should check in ocrd-tool for the number of outputs. We discussed this in the spec, but it is not official, and not implemented yet. Also related to #296.

@bertsky
Copy link
Collaborator

bertsky commented Jul 13, 2020

I cannot find the reference, but I think we agreed that fileGrp names listed in the ocrd-tool.json are merely examples, not fallbacks. Users always have to specifiy these on the command line. So can we close this?

kba added a commit that referenced this issue Jul 14, 2020
@kba
Copy link
Member Author

kba commented Jul 14, 2020

I think we agreed that fileGrp names listed in the ocrd-tool.json are merely examples,

OCR-D/spec#121

-I/-O is currently only required in bashlib, the Python Processor implementations still have fallbacks (INPUT/OUTPUT). Once those are gone, this can be closed.

@kba kba linked a pull request Sep 2, 2020 that will close this issue
@kba kba closed this as completed in #586 Sep 22, 2020
kba added a commit that referenced this issue Sep 22, 2020
show help for no-arg processor calls, fix #562, fix #274
bertsky added a commit to bertsky/core that referenced this issue Dec 1, 2020
bertsky added a commit to bertsky/core that referenced this issue Jun 24, 2024
bertsky added a commit to bertsky/core that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants