Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a linter #92

Closed
3 tasks done
mikegerber opened this issue Oct 12, 2023 · 3 comments · Fixed by #101
Closed
3 tasks done

Use a linter #92

mikegerber opened this issue Oct 12, 2023 · 3 comments · Fixed by #101
Assignees
@mikegerber
Labels
maintenance

Comments

@mikegerber
Copy link
Collaborator

mikegerber commented Oct 12, 2023 •
edited
Loading

#91 should have been caught by a linter.

→ Use pre-commit and ruff here.

  • Re-use config from dinglehopper
  • Fix all issues found by pre-commit run
  • pre-commit autoupdate
@mikegerber mikegerber self-assigned this Oct 12, 2023
@mikegerber
Copy link
Collaborator Author

#91 was a problem in a dependency, so this would have not been caught anyway. Still.

mikegerber added a commit that referenced this issue Oct 17, 2023
@mikegerber
🛠Add pre-commit configuration
94ab7c0 
This pre-commit configuration adds (identical to the configuration in
dinglehopper):

- generic checks
- Black formatting
- ruff linting
- mypy static type checking
- (and a little information on how to enable this)

See also gh-92.
@mikegerber
Copy link
Collaborator Author

ruff was overly strict and removed test.base.assets - need to fix this :)

@mikegerber mikegerber mentioned this issue Oct 18, 2023
Merged
@mikegerber
Copy link
Collaborator Author

ruff was overly strict and removed test.base.assets - need to fix this :)

96ae14c added it back in incl. adding assets to __all__ (which makes ruff keep it in and could potentially also make the pylint pragma unnecessary there.)

@mikegerber mikegerber mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikegerber mikegerber

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use ruff config like dinglehopper's OCR-D/ocrd_calamari
1 participant
@mikegerber