-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add owi c
command and examples for all subcommands
#100
Conversation
As you can see, I got rid of the Makefile, this allows to build everyting with I also moved all the dune-site stuff directly where the files live (for instance we have a I also moved the instrumentor stuff into |
@@ -1 +1,4 @@ | |||
available: (arch = "x86_32" | arch = "x86_64" | arch = "arm64") & os != "win32" | |||
depexts: [ | |||
["llvm" "clang" "lld" "wabt"] {os-family = "debian"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
["llvm" "clang" "lld" "wabt"] {os-family = "debian"} | |
["llvm" "clang" "lld" "wabt"] {os-family = "debian"} | |
["llvm" "wabt"] {os-family = "osx"} |
CI is failing, and it appears to be because we're not specifying the dependencies here. However, I'm not quite sure if these are the only packages required for macOS. Additionally, I couldn't find mentions of lld
or clang
in Homebrew packages, so I assume they must be included in llvm
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I added this line directly myself as running dune b owi.opam
was needed to generate the new owi.opam
file...
Let's see if this is enough 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to have done nothing 😅
I was looking at the os-family
available in here and perhaps wrongfully assumed osx
would work. Inspecting the CI, it looks like it's looking for os-family = "homebrew"
? I have no current way to test this tho, sorry.
...
# Detecting depexts using vars: arch=x86_64, os=macos, os-distribution=homebrew, os-family=homebrew
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, still not. Let's merge as the CI is green on Linux. We'll fix macOS later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least it's installing wabt
and llvm
not. But it's still saying opt: command not found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I saw... @krtab is going to have a look.
owi c
commandowi c
command and examples for all subcommands
I removed the Quick-start section of the README and wrote a short example of all sub-commands we have. It is much better now IMO. You can see how it renders on my fork. |
Co-authored-by: filipeom <33165733+filipeom@users.noreply.github.com>
cc @filipeom