-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: avoid duplicate definition of spi_get_chipselect() with Linux 6.3 #131
Merged
pcolberg
merged 5 commits into
intel/fpga-ofs-dev-6.6-lts
from
pcolberg/spi_get_chipselect
Jul 15, 2024
Merged
backport: avoid duplicate definition of spi_get_chipselect() with Linux 6.3 #131
pcolberg
merged 5 commits into
intel/fpga-ofs-dev-6.6-lts
from
pcolberg/spi_get_chipselect
Jul 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ux 6.3 spi_get_chipselect() was introduced in commit 303feb3cc06a ("spi: Add APIs in spi core to set/get spi->chip_select and spi->cs_gpiod"). Signed-off-by: Peter Colberg <peter.colberg@intel.com>
…ux 6.1.71 spi_get_chipselect() was backported in commit 025cf65f68d4 ("spi: Add APIs in spi core to set/get spi->chip_select and spi->cs_gpiod"). Signed-off-by: Peter Colberg <peter.colberg@intel.com>
Signed-off-by: Peter Colberg <peter.colberg@intel.com>
Debian kernels contain relatively few patches on top of upstream and closely track Linux long-term stable releases as part of Debian stable security updates and point releases.
pcolberg
force-pushed
the
pcolberg/spi_get_chipselect
branch
from
July 15, 2024 18:53
39ec8da
to
39f593f
Compare
pcolberg
commented
Jul 15, 2024
Comment on lines
+14
to
+16
#if LINUX_VERSION_CODE < KERNEL_VERSION(6, 3, 0) && \ | ||
(LINUX_VERSION_CODE < KERNEL_VERSION(6, 1, 71) || \ | ||
LINUX_VERSION_CODE >= KERNEL_VERSION(6, 2, 0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This expression can be simplified since there is only one mainline release ≥6.2 and <6.3, but is kept this way as a template for handling LTS kernels in other cases.
Build modules with latest kernels, e.g., as part of security updates. The minutes are more or less chosen at random, with sufficient wait time between building the containers followed by building the modules using the new containers. The hour falls into the middle of a workday such that a potential breakage does not need to be addressed as the first task of the day, but may still be resolved until end of the day. Signed-off-by: Peter Colberg <peter.colberg@intel.com>
pcolberg
force-pushed
the
pcolberg/spi_get_chipselect
branch
from
July 15, 2024 19:18
f508a5c
to
2822a68
Compare
fpgamatt
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spi_get_chipselect() was introduced in commit 303feb3cc06a ("spi: Add APIs in spi core to set/get spi->chip_select and spi->cs_gpiod").