Feat/v3 rtss #3092
Feat/v3 rtss #3092
Conversation
✅ Deploy Preview for ohif-platform-viewer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ohif-platform-docs canceled.
|
Codecov Report
@@ Coverage Diff @@
## v3-stable #3092 +/- ##
==============================================
+ Coverage 25.15% 39.83% +14.67%
==============================================
Files 119 96 -23
Lines 2862 2036 -826
Branches 555 420 -135
==============================================
+ Hits 720 811 +91
+ Misses 1856 1002 -854
+ Partials 286 223 -63
Continue to review full report at Codecov.
|
| @@ -31,6 +31,10 @@ | |||
| { | |||
| "packageName": "@ohif/extension-cornerstone-dicom-seg", | |||
| "version": "3.0.0" | |||
| }, | |||
| { | |||
| "packageName": "dicom-rtss", | |||
There was a problem hiding this comment.
can we name this extension dicom-rt?
There was a problem hiding this comment.
Will do, I will make this modification along with the colors in the next commit.
| @@ -0,0 +1,73 @@ | |||
| { | |||
| "name": "dicom-rtss", | |||
There was a problem hiding this comment.
please see other package.json and follow their namings
|
For some reason the exported RT looks like this Do you have any idea why? |
|
Would you be able to also show the original segmentation? It looks like the contour is outside of the volume, but that should not be happening as the vtkjs routine to my knowledge is based on the segmentation volume, which should be identical to the image volume. |
|
Any chance you can look at my comment? |
Sorry I hadn't had a chance to look at this again for a while, I'll try to take a look later this week. Would you be able to note the tool/steps you used to create the segmentation? When I did my testing I had only used the brush tool so I may need to test with a variety of tools. |
|
We should move this logic inside @cornerstonejs/adapters |
|
@dxlin as discussed we are going to close this and you will create a new PR |
PR Checklist
@mentiona maintainer to request a reviewHi @sedghi, sorry for the delay with this.
This is the code that exports/converts current segmentations to RTSS dicom files. This is invoked via the commands exportRTSS or uploadRTSS (depending if want to download to local or upload to PACS).
Originally we had discussed putting this code within cornerstone or dcmjs, but ultimately I felt like it may have been easier and more concise to keep this as an extension. At the moment the RTSS upload portion only uploads a new RTSS dicom, but once I can see the import code I can also work to revise it so that it replaces if the segmentation affected was from a previously existing RTSS dicom.
Sorry for the delay, had some difficulties with bugs the conversion when segmentations intersect with the border of the image volume.