Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tmtv): threshold was crashing the side panel #4119

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

IbrahimCSAE
Copy link
Collaborator

Context

threshold was crashing the side panel

Changes & Results

fix the typos that were causing the threshold panel to crash

Copy link

netlify bot commented May 13, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 340d6b6
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6644ac286476d500081b3485
😎 Deploy Preview https://deploy-preview-4119--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 340d6b6
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6644ac28977bdf000863366b
😎 Deploy Preview https://deploy-preview-4119--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi May 13, 2024 16:04
Copy link

cypress bot commented May 13, 2024

Passing run #3909 ↗︎

0 43 0 0 Flakiness 0

Details:

fix names
Project: Viewers Commit: 340d6b6211
Status: Passed Duration: 06:21 💡
Started: May 15, 2024 12:48 PM Ended: May 15, 2024 12:54 PM

Review all test suite changes for PR #4119 ↗︎

@IbrahimCSAE IbrahimCSAE requested a review from sedghi May 15, 2024 13:09
@sedghi sedghi merged commit 8d5c676 into master May 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants