fix(auth): bind handleUnauthenticated to correct context #4120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The issue was that the
handleUnauthenticated
function passed as a prop to thePrivateRoute
component was a regular function, which caused a scope issue withthis
. In this function,this
referred to the global object instead of the instance ofuserAuthenticationService
.-
public handleUnauthenticated() { return this.serviceImplementation._handleUnauthenticated(); }
The value of
this
was undefined instead of referring to the instance ofuserAuthenticationService
.Changes & Results
I modified the code to pass an arrow function instead of a regular function to the
PrivateRoute
component. This way,this
is correctly bound to the context ofuserAuthenticationService
.Before:
-
<PrivateRoute handleUnauthenticated={userAuthenticationService.handleUnauthenticated}>
After:
-
<PrivateRoute handleUnauthenticated={() => userAuthenticationService.handleUnauthenticated()}>
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment