Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segmentation): Address issue where segmentation creation failed on layout change #4153

Merged
merged 7 commits into from
May 21, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented May 21, 2024

Context

Tries to address this issue #4046

Where you could not create a segmentation when layout it chnaged

Changes & Results

add default toolGroupId

Testing

checkout #4046

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented May 21, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 83321db
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/664d000f227e2d0008eec0cf
😎 Deploy Preview https://deploy-preview-4153--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 83321db
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/664d000f2107570009fb4f5c
😎 Deploy Preview https://deploy-preview-4153--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi changed the title fix/layout stuff fix(segmentation): Address issue where segmentation creation failed on layout change May 21, 2024
@sedghi sedghi requested a review from IbrahimCSAE May 21, 2024 16:01
Copy link

cypress bot commented May 21, 2024

Passing run #3940 ↗︎

0 43 0 0 Flakiness 0

Details:

yarn lock
Project: Viewers Commit: 83321db8c0
Status: Passed Duration: 05:51 💡
Started: May 21, 2024 8:32 PM Ended: May 21, 2024 8:38 PM

Review all test suite changes for PR #4153 ↗︎

@sedghi sedghi merged commit 29944c8 into master May 21, 2024
9 checks passed
sedghi added a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants