Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/579/20240919/v1 #435

Merged
merged 1 commit into from
Sep 20, 2024
Merged

next/579/20240919/v1 #435

merged 1 commit into from
Sep 20, 2024
+3 −3

Conversation

victorjulien
Copy link
Member

@inashivb
htp/table: only fetch element when needed
09d8110 
It is unnecessary to always fetch the element as it is only needed when
there is a match. Get the list item only when the key candidate matches
the key parameter and the element needs to be returned. This will ensure
lesser calls to htp_list_get fn.
inashivb
inashivb approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 22752

@victorjulien victorjulien merged commit 09d8110 into OISF:0.5.x Sep 20, 2024
10 checks passed
@victorjulien victorjulien mentioned this pull request Sep 20, 2024
Merged
@victorjulien victorjulien deleted the next/579/20240919/v1 branch September 20, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inashivb inashivb inashivb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @suricata-qa @inashivb