Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/675/20241219/v1 #437

Merged
merged 1 commit into from
Dec 20, 2024
Merged

next/675/20241219/v1 #437

merged 1 commit into from
Dec 20, 2024

Conversation

victorjulien
Copy link
Member

@victorjulien
scan-build: work around optin.performance.Padding
46b43fd 
Since the layout has to be preserved, padding is added.
jasonish
jasonish approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should have no adverse side affects. Sure is ugly cruft to carry around tho!

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24030

@victorjulien victorjulien merged commit 46b43fd into OISF:0.5.x Dec 20, 2024
10 checks passed
@victorjulien victorjulien mentioned this pull request Dec 20, 2024
Merged
@victorjulien victorjulien deleted the next/675/20241219/v1 branch December 20, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @suricata-qa @jasonish