Detect cleanups/0712/v2 #10003
Closed
Detect cleanups/0712/v2 #10003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing Address specific going on in the preparations. Stage 1: Preprocessing happens. Sigs classified as IP Only, Masks applied, content specific limits applied, etc and sig array built. Stage 2: Sigs grouped by IPOnly, ports and protocols. Stage 3: Decoder Events SGH built. Stage 4: File flags set, sig grouping done per prefilter, etc.
The flag SIG_FLAG_MPM_NEG is set before whitelisting the rules. Make it better by checking for the flag in the beginning and return immediately.
victorjulien
approved these changes
Dec 7, 2023
|
Information: QA ran without warnings. Pipeline 16938 |
Merged
|
Merged in #10028, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #9998
Changes since v1:
RuleMpmIsNegatedreturn bool too