Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/596/20241008/v1 #11905

Merged
merged 3 commits into from
Oct 9, 2024
Merged

next/596/20241008/v1 #11905

merged 3 commits into from
Oct 9, 2024

Conversation

victorjulien
Copy link
Member

zemeteri and others added 3 commits October 8, 2024 13:02
@zemeteri @victorjulien
detect: add new_de_ctx release in case of errors in initialization
adcac9e 
Detect engine tenant reloading function hasn't got engine release call
under error label, so it is possible memory leak in case of errors in
further new detect engine initialization.

Bug: OISF#7303
@catenacyber @victorjulien
transform/base64: check for 0-sized buffer
40e9742 
So as to avoid undefined behavior with a 0-sized variable length
array

Ticket: OISF#7296
@AkakiAlice @victorjulien
detect/address: convert ipv4 unittests to FAIL/PASS
d5dd549 
Ticket: OISF#6318
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.61111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.70%. Comparing base (6ae5ae7) to head (d5dd549).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11905      +/-   ##
==========================================
+ Coverage   82.60%   82.70%   +0.09%     
==========================================
  Files         912      912              
  Lines      249342   249102     -240     
==========================================
+ Hits       205968   206018      +50     
+ Misses      43374    43084     -290
Flag Coverage Δ
fuzzcorpus 60.68% <16.66%> (+0.04%) ⬆️
livemode 18.72% <0.00%> (+<0.01%) ⬆️
pcap 44.10% <0.00%> (+0.03%) ⬆️
suricata-verify 62.14% <33.33%> (+0.12%) ⬆️
unittests 58.99% <98.26%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23044

@victorjulien victorjulien merged commit d5dd549 into OISF:master Oct 9, 2024
61 checks passed
This was referenced Oct 9, 2024
Closed
Closed
Closed
@victorjulien victorjulien deleted the next/596/20241008/v1 branch October 9, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@victorjulien @suricata-qa @jasonish @zemeteri @catenacyber @AkakiAlice