Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Training/ams2018/v4 #3487

Merged
merged 24 commits into from
Sep 20, 2018
Merged

Training/ams2018/v4 #3487

merged 24 commits into from
Sep 20, 2018

Conversation

victorjulien
Copy link
Member

Updates to setup scripts and templates. Includes #3480 and #3485

PRScript output (if applicable):

victorjulien and others added 24 commits September 19, 2018 10:57
@victorjulien
detect/template: clean up unittest
234d113
@victorjulien
detect/template: switch to v2 API, add MPM
1bb8fce
@victorjulien
detect/template: move test to own file in src/tests/
d3e5c15
@victorjulien
detect/template: clean up packet keyword
33914c2
@victorjulien
app-layer/template: code cleanups
a013cec
@jasonish @victorjulien
setup-app-layer: rewrite script in Python
e232fcc 
The idea being that it is easier to read and maintain than
wrapping ed commands.

This script also merges the parser and logger setup into a single
script, but still allows just the parser, or just the logger
to be generated with flags, --logger and --parser.
@jasonish @victorjulien
scripts/setup: remove 'ed' based setup scripts
9da00be 
Removes:
- setup-app-layer.sh
- setup-app-layer-logger.sh

These have been replaced by setup-app-layer.py.
@victorjulien
setup-simple-detect: update for new tests location
452355b
@victorjulien
setup-app-layer-detect: update for tests/ dir
5ed7e4f
@victorjulien
decode/template: minor updates
4d0fc67
@victorjulien
detect/template2: template with prefilter (copy of ttl)
4860545
@victorjulien
detect/template2: setup script
789b147
@jasonish @victorjulien
templates: C stub template for Rust parser
96dc20a
@jasonish @victorjulien
templates: C stub output for Rust logger
ee3aba9
@jasonish @victorjulien
rust/gen-c-headers: don't attempt to split empty lines
90dfcf4
@jasonish @victorjulien
rust: expose AppLayerParserStateIssetFlag to Rust.
9636b9d
@jasonish @victorjulien
rustfmt.toml: set to 80 char line width
7682b1b 
The rustfmt default is 100, set to 80 to be more inline with
the Suricata C code.
@jasonish @victorjulien
rust: app-layer template parser and logger
c3f1a35 
The protocol is a simple request/reply based protocol that can
be hand driven with netcat.

Request  -> 12:Hello World!
Response -> 3:Byte

Its of the format <length>:<message> where length is the length
of the message, not including the length or the delimiter.
@jasonish @victorjulien
rust template parser: sample pcap
01f7dcf
@jasonish @victorjulien
rust app layer template: functions to get buffers
58933ba 
Example functions for getting the request and response buffers.
Useful for running detection on the decoded buffers.
@jasonish @victorjulien
setup-app-layer.py: attempt to cd into correct directory
15922dc 
- If in src, cd to ..
- Error out early if the current directory does not look like a
  Suricata source directory.
@jasonish @victorjulien
rust: app-layer detect template for rust parsers
35fd10b
@jasonish @victorjulien
setup-app-layer.py: integrate detect buffer setup
7ec7d85 
Add --detect to setup a detect buffer.

Obsoletes setup-app-layer-detect.sh.
@victorjulien
setup-app-layer: support tests in tests/
0b5a2ab
@victorjulien victorjulien requested review from jasonish and a team as code owners September 20, 2018 15:40
jasonish
jasonish approved these changes Sep 20, 2018
View reviewed changes
Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through a series of setups and all is good. Detect test in tests/ directory runs fine.

We'll cleanup the template2 stuff after training.

@inliniac inliniac merged commit 0b5a2ab into OISF:master Sep 20, 2018
This was referenced Sep 20, 2018
Closed
Closed
catenacyber added a commit to catenacyber/suricata that referenced this pull request Nov 27, 2023
@catenacyber
smtp: use rust for mime parsing
32bf3b4 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Dec 5, 2023
@catenacyber
http: use rust for mime parsing
826e9a1 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Dec 5, 2023
@catenacyber
smtp: use rust for mime parsing
99de884 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Dec 5, 2023
@catenacyber
smtp: use rust for mime parsing
f82ee51 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Feb 2, 2024
@catenacyber
http: use rust for mime parsing
815021a 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Feb 2, 2024
@catenacyber
smtp: use rust for mime parsing
c3e0e1d 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Feb 12, 2024
@catenacyber
http: use rust for mime parsing
1224dbf 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Feb 12, 2024
@catenacyber
smtp: use rust for mime parsing
cb9bb7f 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Mar 1, 2024
@catenacyber
http: use rust for mime parsing
287b87d 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Mar 1, 2024
@catenacyber
smtp: use rust for mime parsing
16a0561 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Mar 28, 2024
@catenacyber
http: use rust for mime parsing
dd900b2 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Mar 28, 2024
@catenacyber
smtp: use rust for mime parsing
a7376a6 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 22, 2024
@catenacyber
http: use rust for mime parsing
58ce20c 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 22, 2024
@catenacyber
smtp: use rust for mime parsing
be7bec2 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 23, 2024
@catenacyber
http: use rust for mime parsing
29e7b1f 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 23, 2024
@catenacyber
smtp: use rust for mime parsing
c9e2214 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 27, 2024
@catenacyber
http: use rust for mime parsing
f57aea7 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 27, 2024
@catenacyber
smtp: use rust for mime parsing
f36d8f7 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 30, 2024
@catenacyber
http: use rust for mime parsing
56a7035 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 30, 2024
@catenacyber
smtp: use rust for mime parsing
9deebf2 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 30, 2024
@catenacyber
http: use rust for mime parsing
cfb677b 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request May 30, 2024
@catenacyber
smtp: use rust for mime parsing
caac559 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jun 2, 2024
@catenacyber
http: use rust for mime parsing
0a35997 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jun 2, 2024
@catenacyber
smtp: use rust for mime parsing
69a1f7d 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jun 3, 2024
@catenacyber
http: use rust for mime parsing
9d71719 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jun 3, 2024
@catenacyber
smtp: use rust for mime parsing
9a7c5c6 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jun 3, 2024
@catenacyber
smtp: use rust for mime parsing
d9aa34b 
Ticket: OISF#3487
catenacyber added a commit to catenacyber/suricata that referenced this pull request Jun 3, 2024
@catenacyber
smtp: use rust for mime parsing
db8d562 
Ticket: OISF#3487
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Jun 4, 2024
@catenacyber @victorjulien
http: use rust for mime parsing
5f75b9a 
Ticket: OISF#3487
victorjulien pushed a commit to victorjulien/suricata that referenced this pull request Jun 4, 2024
@catenacyber @victorjulien
smtp: use rust for mime parsing
a10c1f1 
Ticket: OISF#3487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish jasonish approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorjulien @jasonish @inliniac