fuzz: improves sigpcap target with PacketPoolInit #5672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Sep 5, 2024
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Sep 5, 2024
Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Sep 5, 2024
After a GAP, remove any entry from the guid2name_map that is older than 30s. Update C unittest to make sure Flow timestamps are initialized. Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Sep 17, 2024
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Sep 17, 2024
Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Sep 17, 2024
After a GAP, remove any entry from the guid2name_map that is older than 30s. Update C unittest to make sure Flow timestamps are initialized. Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 24, 2024
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 24, 2024
Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 25, 2024
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 25, 2024
Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 25, 2024
Use `lru` crate. Rename to reflect this. Add `app-layer.protocols.smb.max-guid-cache-size` to control the max size of the LRU cache. Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 25, 2024
Rename to read_offset_cache. Add `app-layer.protocols.smb.max-read-offset-cache-size` option to control the limit. Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 25, 2024
Turn the map mapping the smb session key to smb tree into a lru cache, limited to 1024 by default. Add `app-layer.protocols.smb.max-tree-cache-size` option to control the limit. Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 25, 2024
Reimplement the ssnguid2vec_map HashMap as a LruCache. Since this is a DCERPC record cache, name it as such. Default size is 128. Can be controlled by `app-layer.protocols.smb.max-dcerpc-frag-cache-size`. Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 25, 2024
Generic ssn2vec_map was a HashMap used for mapping session key to different types of vector data: - GUID - filename - share name Turn this into a bounded LruCache. Rename to ssn2vec_cache. Size of the cache is 512 by default, and can be configured using: `app-layer.protocols.smb.max-session-cache-size` Ticket: OISF#5672.
victorjulien
added a commit
to victorjulien/suricata
that referenced
this pull request
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4125
Describe changes:
PacketPoolInitinstead ofPacketPoolInitEmptyFixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=28390