log/diag: Support diagnostic stacktraces on unexpected signals #6309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for enabling libunwind -- a library that can be used to display stack information. Use --enable-libunwind to check for availability. A diagnostic message is displayed if libunwind cannot be found as requested.
This commit adds an error code for the diagnostic code used for diagnostic messages following unexpected termination due to signals..
This commit adds a configuration setting to enable a stack trace message if Suricata receives a signal that terminates execution, such as SIGSEGV, SIGABRT.
This commit adds a signal handler for SIGSEGV when configured. The signal handler emits a one line stack trace using SCLogError. The intent is to provide diagnostic information in deployments where core files are not possible. The diagnostic message is from the offending thread and includes the stack trace; each frame includes the symbol + offset.
Codecov Report
@@ Coverage Diff @@
## master #6309 +/- ##
==========================================
- Coverage 76.97% 76.93% -0.05%
==========================================
Files 611 611
Lines 185941 185957 +16
==========================================
- Hits 143130 143066 -64
- Misses 42811 42891 +80
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 3920 |
|
Would it make sense to enable this by default if |
|
I think it would make sense to always have it since the overhead is quite low. |
|
Continued in #6338 |
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Oct 23, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Oct 24, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Oct 25, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Oct 25, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 5, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 7, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 7, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 8, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 11, 2023
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 11, 2023
3 tasks
hadiqaalamdar
added a commit
to hadiqaalamdar/suricata
that referenced
this pull request
Dec 13, 2023
3 tasks
victorjulien
pushed a commit
to victorjulien/suricata
that referenced
this pull request
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #6243
This PR supports configuring Suricata to emit a one-line diagnostic message containing a stacktrace when a signal that terminates Suricata execution (e.g., SIGABRT or SIGSEGV) occurs.
Requires:
--enable-libunwindto configure supportlibunwindmust be available for when building Suricatalogging.stacktrace-on-signal)Example output:
Link to redmine ticket: 4526
Describe changes:
onwhen configured with--enable-libunwind.#suricata-verify-pr:
#suricata-verify-repo:
#suricata-verify-branch:
#suricata-update-pr:
#suricata-update-repo:
#suricata-update-branch:
#libhtp-pr:
#libhtp-repo:
#libhtp-branch: