Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: configures libhtp to allow spaces in uri #6359

Closed
wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/2881

Describe changes:

  • configures libhtp to allow spaces in URIs

Modifies #5413 with rebase

suricata-verify-pr:328
libhtp-pr: 330

OISF/suricata-verify#328
OISF/libhtp#330

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #6359 (4585a09) into master (ca760e3) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6359      +/-   ##
==========================================
+ Coverage   76.96%   76.98%   +0.01%     
==========================================
  Files         612      612              
  Lines      186410   186410              
==========================================
+ Hits       143477   143500      +23     
+ Misses      42933    42910      -23     
Flag Coverage Δ
fuzzcorpus 52.71% <ø> (-0.04%) ⬇️
suricata-verify 51.55% <ø> (+0.03%) ⬆️
unittests 63.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

WARNING:

field test baseline %
tlpr1_stats_chk
.flow.mgr.rows_maxlen 539 404 133.42%
.detect.alert 3090948 3947262 78.31%

Pipeline 4117

1 similar comment
@suricata-qa
Copy link

WARNING:

field test baseline %
tlpr1_stats_chk
.flow.mgr.rows_maxlen 539 404 133.42%
.detect.alert 3090948 3947262 78.31%

Pipeline 4117

@suricata-qa
Copy link

WARNING:

ERROR: QA failed on tlpr1_alerts_cmp.

field test baseline %
tlpr1_stats_chk
.flow.mgr.rows_maxlen 539 404 133.42%
.detect.alert 3090948 3947262 78.31%

Pipeline 4117

@victorjulien
Copy link
Member

I'm looking at the libhtp side of this. If that is clean in my QA I'll merge it and we can see if this Suricata PR no longer causes deviation.

@victorjulien
Copy link
Member

I'm looking at the libhtp side of this. If that is clean in my QA I'll merge it and we can see if this Suricata PR no longer causes deviation.

Libhtp side is merged.

@catenacyber
Copy link
Contributor Author

I'm looking at the libhtp side of this. If that is clean in my QA I'll merge it and we can see if this Suricata PR no longer causes deviation.

Libhtp side is merged.

Everything rebased in #6882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants