[draft] Rewrite suricatasc in Rust - v0 #8571
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #8571 +/- ##
==========================================
- Coverage 82.16% 82.15% -0.01%
==========================================
Files 968 969 +1
Lines 274204 274213 +9
==========================================
- Hits 225302 225292 -10
- Misses 48902 48921 +19
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
WARNING:
Pipeline 12678 |
|
Do we have options to selectively vendor things, e.g. indeed excluding windows specific crates? |
No, its been a long standing issue: rust-lang/cargo#7058 Most common option these days is to delete the stuff you know won't be needed. |
jasonish
force-pushed
the
rust-suricatactl/v0
branch
from
d098477
to
72b513a
Compare
|
Information: QA ran without warnings. Pipeline 13590 |
jasonish
force-pushed
the
rust-suricatactl/v0
branch
from
ea0bbc5
to
780f5dd
Compare
|
WARNING:
Pipeline 13620 |
|
What is the difference in the size of the dist with and without the windows stuff? |
jasonish
force-pushed
the
rust-suricatactl/v0
branch
from
21017d0
to
4764c3c
Compare
7.0.0-rc1 was 22 MB. However, pruning the vendor directory still causes failures build failures on Windows. So far only the the verification of dependencies, not actually compile. So maybe that could be patched up at vendor time as well, but probably to find another issue. Which is silly, cause we don't even build the part that enters this dependency chain on Windows. Maybe refactoring the layout a bit and some autoconf glue might be a better path to look at next. |
|
Information: QA ran without warnings. Pipeline 13637 |
jasonish
force-pushed
the
rust-suricatactl/v0
branch
from
4764c3c
to
223b858
Compare
|
WARNING:
Pipeline 13741 |
|
What do you expect here @jasonish ? |
This is just more of an experimentation with eliminating Python from end-user distributable, given its probably only get harder to keep such tooling working as Python marches forward. I plan to keep this up to date, its not 100% yet replacing our Pythonctl tool. |
jasonish
force-pushed
the
rust-suricatactl/v0
branch
from
223b858
to
7757f81
Compare
|
WARNING:
Pipeline 13741 |
|
Is there a ticket for this ? |
Is now https://redmine.openinfosecfoundation.org/issues/6287. |
jasonish
force-pushed
the
rust-suricatactl/v0
branch
4 times, most recently
from
78c0c54
to
4cb041b
Compare
This is a re-implementation of suricatasc program in Rust that attempts to be a 100% drop-in replacement. This adds 2 crates, the "client" and "suricatasc". The idea is that the client is a more permissively licensed crate for communicating with a Suricata server.
As we have 2 Windows builds, do one using the release-style distribution file.
jasonish
force-pushed
the
rust-suricatactl/v0
branch
from
4cb041b
to
c29d2c4
Compare
jasonish
force-pushed
the
rust-suricatactl/v0
branch
from
c29d2c4
to
5c210fd
Compare
jasonish
force-pushed
the
rust-suricatactl/v0
branch
from
5c210fd
to
32f7c2e
Compare
|
Information: QA ran without warnings. Pipeline 15851 |
|
Information: QA ran without warnings. Pipeline 15852 |
|
Replaced by #9817. |
This is a reimplementation of suricatasc I've been sitting on for about a year
as I didn't get around to fixing the Windows compilation issue (now fixed).
What I don't like is how the vendor size has grown due to the Rust
reedline-like lib, "rustyline" pulling in all sorts of Windows crates as it's
cross platform. We could just delete those and we don't build the full
suricatasc tool on Windows yet due to unix sockets being required.
This aims to be 100% compatible with the current Python "suricatasc".
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6287