[chromeperf] Update anomaly type with reporting info

Anomaly type will have the info needed for triaging: - subscription name - bug component - bug labels - bug cc emails. Bug: b/365007664 Change-Id: I02abaec7f9ed3b90aa9106afc8a8ef24b5f7cea2 Reviewed-on: https://skia-review.googlesource.com/c/buildbot/+/897284 Reviewed-by: Eduardo Yap <eduardoyap@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
OKEAMAH · Sep 9, 2024 · c7cca53 · c7cca53
1 parent 75f59f4
commit c7cca53
Show file tree

Hide file tree

Showing 9 changed files with 63 additions and 21 deletions.
diff --git a/perf/go/chromeperf/anomalyApi.go b/perf/go/chromeperf/anomalyApi.go
@@ -32,24 +32,28 @@ type AnomalyMap map[string]CommitNumberAnomalyMap
 
 // Anomaly defines the object return from Chrome Perf API.
 type Anomaly struct {
-	Id                  int     `json:"id"`
-	TestPath            string  `json:"test_path"`
-	BugId               int     `json:"bug_id"`
-	StartRevision       int     `json:"start_revision"`
-	EndRevision         int     `json:"end_revision"`
-	IsImprovement       bool    `json:"is_improvement"`
-	Recovered           bool    `json:"recovered"`
-	State               string  `json:"state"`
-	Statistics          string  `json:"statistic"`
-	Unit                string  `json:"units"`
-	DegreeOfFreedom     float64 `json:"degrees_of_freedom"`
-	MedianBeforeAnomaly float64 `json:"median_before_anomaly"`
-	MedianAfterAnomaly  float64 `json:"median_after_anomaly"`
-	PValue              float64 `json:"p_value"`
-	SegmentSizeAfter    int     `json:"segment_size_after"`
-	SegmentSizeBefore   int     `json:"segment_size_before"`
-	StdDevBeforeAnomaly float64 `json:"std_dev_before_anomaly"`
-	TStatistics         float64 `json:"t_statistic"`
+	Id                  int      `json:"id"`
+	TestPath            string   `json:"test_path"`
+	BugId               int      `json:"bug_id"`
+	StartRevision       int      `json:"start_revision"`
+	EndRevision         int      `json:"end_revision"`
+	IsImprovement       bool     `json:"is_improvement"`
+	Recovered           bool     `json:"recovered"`
+	State               string   `json:"state"`
+	Statistics          string   `json:"statistic"`
+	Unit                string   `json:"units"`
+	DegreeOfFreedom     float64  `json:"degrees_of_freedom"`
+	MedianBeforeAnomaly float64  `json:"median_before_anomaly"`
+	MedianAfterAnomaly  float64  `json:"median_after_anomaly"`
+	PValue              float64  `json:"p_value"`
+	SegmentSizeAfter    int      `json:"segment_size_after"`
+	SegmentSizeBefore   int      `json:"segment_size_before"`
+	StdDevBeforeAnomaly float64  `json:"std_dev_before_anomaly"`
+	TStatistics         float64  `json:"t_statistic"`
+	SubscriptionName    string   `json:"subscription_name"`
+	BugComponent        string   `json:"bug_component"`
+	BugLabels           []string `json:"bug_labels"`
+	BugCcEmails         []string `json:"bug_cc_emails"`
 }
 
 // AnomalyForRevision defines struct to contain anomaly data for a specific revision

diff --git a/perf/go/chromeperf/anomalyApi_test.go b/perf/go/chromeperf/anomalyApi_test.go
@@ -119,10 +119,16 @@ func TestGetAnomaly_Success(t *testing.T) {
 	test := "myTest"
 	subtest := "mysubtest"
 	testPath := fmt.Sprintf("%s/%s/%s/%s/%s", master, bot, benchmark, test, subtest)
+	subscription_name := "sub_name"
+	bug_component := "bug_component"
+	bug_labels := []string{"label1", "label2", "label3"}
 	anomaly := Anomaly{
-		StartRevision: 1111,
-		EndRevision:   2222,
-		TestPath:      testPath,
+		StartRevision:    1111,
+		EndRevision:      2222,
+		TestPath:         testPath,
+		SubscriptionName: subscription_name,
+		BugComponent:     bug_component,
+		BugLabels:        bug_labels,
 	}
 	anomalyResponse := &GetAnomaliesResponse{
 		Anomalies: map[string][]Anomaly{
@@ -147,6 +153,10 @@ func TestGetAnomaly_Success(t *testing.T) {
 	assert.Equal(t, benchmark, params["benchmark"][0])
 	assert.Equal(t, test, params["test"][0])
 	assert.Equal(t, subtest, params["subtest_1"][0])
+	assert.Equal(t, subscription_name, anomalyResp.SubscriptionName)
+	assert.Equal(t, bug_component, anomalyResp.BugComponent)
+	assert.Equal(t, 3, len(anomalyResp.BugLabels))
+	assert.Equal(t, 0, len(anomalyResp.BugCcEmails))
 }
 
 func TestGetAnomaly_InvalidChar_Success(t *testing.T) {

diff --git a/perf/modules/anomaly-sk/anomaly-sk-demo.ts b/perf/modules/anomaly-sk/anomaly-sk-demo.ts
@@ -45,6 +45,10 @@ const dummyAnomaly = (bugId: number): Anomaly => ({
   segment_size_before: 0,
   std_dev_before_anomaly: 0,
   t_statistic: 0,
+  subscription_name: '',
+  bug_component: '',
+  bug_labels: [],
+  bug_cc_emails: [],
 });
 
 // The response to a POST of [64809, 64811] to /_/cid/.

diff --git a/perf/modules/anomaly-sk/anomaly-sk_test.ts b/perf/modules/anomaly-sk/anomaly-sk_test.ts
@@ -35,6 +35,10 @@ const dummyAnomaly = (): Anomaly => ({
   segment_size_before: 0,
   std_dev_before_anomaly: 0,
   t_statistic: 0,
+  subscription_name: '',
+  bug_component: '',
+  bug_labels: [],
+  bug_cc_emails: [],
 });
 
 describe('getAnomalyDataMap', () => {

diff --git a/perf/modules/chart-tooltip-sk/chart-tooltip-sk-demo.ts b/perf/modules/chart-tooltip-sk/chart-tooltip-sk-demo.ts
@@ -47,6 +47,10 @@ const dummyAnomaly = (bugId: number): Anomaly => ({
   segment_size_before: 0,
   std_dev_before_anomaly: 0,
   t_statistic: 0,
+  subscription_name: '',
+  bug_component: '',
+  bug_labels: [],
+  bug_cc_emails: [],
 });
 
 // The response to a POST of [64809, 64811] to /_/cid/.

diff --git a/perf/modules/chart-tooltip-sk/chart-tooltip-sk_test.ts b/perf/modules/chart-tooltip-sk/chart-tooltip-sk_test.ts
@@ -65,6 +65,10 @@ describe('chart-tooltip-sk', () => {
     segment_size_before: 0,
     std_dev_before_anomaly: 0,
     t_statistic: 0,
+    subscription_name: '',
+    bug_component: '',
+    bug_labels: [],
+    bug_cc_emails: [],
   });
 
   describe('set fields', () => {

diff --git a/perf/modules/explore-simple-sk/explore-simple-sk_test.ts b/perf/modules/explore-simple-sk/explore-simple-sk_test.ts
@@ -53,6 +53,10 @@ const dummyAnomaly: Anomaly = {
   segment_size_before: 0,
   std_dev_before_anomaly: 0,
   t_statistic: 0,
+  subscription_name: '',
+  bug_component: '',
+  bug_labels: [],
+  bug_cc_emails: [],
 };
 
 describe('calculateRangeChange', () => {

diff --git a/perf/modules/json/index.ts b/perf/modules/json/index.ts
@@ -162,6 +162,10 @@ export interface Anomaly {
 	segment_size_before: number;
 	std_dev_before_anomaly: number;
 	t_statistic: number;
+	subscription_name: string;
+	bug_component: string;
+	bug_labels: string[] | null;
+	bug_cc_emails: string[] | null;
 }
 
 export interface FrameResponse {

diff --git a/perf/modules/plot-simple-sk/plot-simple-sk-demo.ts b/perf/modules/plot-simple-sk/plot-simple-sk-demo.ts
@@ -39,6 +39,10 @@ const dummyAnomaly = (isImprovement: boolean): Anomaly => ({
   segment_size_before: 0,
   std_dev_before_anomaly: 0,
   t_statistic: 0,
+  subscription_name: '',
+  bug_component: '',
+  bug_labels: [],
+  bug_cc_emails: [],
 });
 
 window.customElements.whenDefined('plot-simple-sk').then(() => {