Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full div image in how-to introduction #1180

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Full div image in how-to introduction #1180

merged 1 commit into from
Jul 14, 2021

Conversation

davehakkens
Copy link
Contributor

@davehakkens davehakkens commented Jun 29, 2021

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The image in the how-to will show full div. This will remove the white space on the bottom and make it look pretty 💫

Screenshots/Videos

before-after

The image in the how-to will show full div. This will remove the white space on the bottom and make it look pretty 💫
@davehakkens davehakkens changed the title Full div image in how-to Full div image in how-to introduction Jun 29, 2021
@cypress
Copy link

cypress bot commented Jun 29, 2021



Test summary

68 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit 642e4d5
Started Jun 29, 2021 4:35 PM
Ended Jun 29, 2021 4:39 PM
Duration 04:42 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke chrismclarke added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jul 14, 2021
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 642e4d5):

https://onearmy-next--pr1180-dave-edit-j47bjj8o.web.app

(expires Fri, 13 Aug 2021 20:23:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@chrismclarke chrismclarke self-requested a review July 14, 2021 22:38
Copy link
Member

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@chrismclarke chrismclarke merged commit fe544c1 into master Jul 14, 2021
@chrismclarke chrismclarke deleted the dave-edit branch July 14, 2021 22:39
@davehakkens davehakkens restored the dave-edit branch July 27, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: HowTo 📰 Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants