Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/research routes #1187

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Fix/research routes #1187

merged 2 commits into from
Jul 14, 2021

Conversation

chrismclarke
Copy link
Member

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • Bug fix (non-breaking change which fixes an issue)

Description

Fix issue where /create page looks for research item named create instead of going to create page (route priority order)

Git Issues

Closes #

Screenshots/Videos

If useful, provide screenshot or capture to highlight main changes


What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

@cypress
Copy link

cypress bot commented Jul 8, 2021



Test summary

68 0 0 0Flakiness 1


Run details

Project onearmy-community-platform
Status Passed
Commit de169dc
Started Jul 8, 2021 6:03 PM
Ended Jul 8, 2021 6:09 PM
Duration 06:00 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/sign-up.spec.ts Flakiness
1 [Sign-up - new user] > sign in as new user

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrismclarke chrismclarke added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jul 14, 2021
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit de169dc):

https://onearmy-next--pr1187-fix-research-routes-x3ubyay1.web.app

(expires Fri, 13 Aug 2021 20:20:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@chrismclarke chrismclarke merged commit 91df179 into master Jul 14, 2021
@chrismclarke chrismclarke deleted the fix/research-routes branch July 14, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Research 🔬 Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant