fix map pin detail #1188
Merged
fix map pin detail #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismclarke
added
the
Review allow-preview ✅
|
Visit the preview URL for this PR (updated for commit d13b4f7): https://onearmy-next--pr1188-fix-map-pin-details-mw08zltt.web.app (expires Fri, 13 Aug 2021 22:33:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
nice |
davehakkens
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
masterbranch mergedPR Type
Description
When mappins load they should retrieve details from db (including verified badge), except some legacy mappins already have details hardcoded and so were skipping this step. This PR fixes the behaviour (force always to look at db and ignore hardcoded data), as well as some minor code tidying.
Git Issues
Closes #
Screenshots/Videos
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on slack in the
platform-devchannel.