Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auth system local overrides and comments auth #1191

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

chrismclarke
Copy link
Member

@chrismclarke chrismclarke commented Jul 20, 2021

PR Checklist

  • - Latest master branch merged
  • - PR title descriptive (can be used in release notes)

PR Type

  • New feature (non-breaking change which adds functionality)

Description

  • Add dev site override so developers can test different user auth roles (e.g admin, beta-tester)
  • Update howto comments system so that comments can be seen by all but only created by beta-testers

Git Issues

Closes #

Screenshots/Videos

platform-auth-comments.mp4

What happens next?

Thanks for the contribution! We try to make sure all PRs are reviewed ahead of a monthly dev call (first Monday of the month, open to all!).

If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.

If you need more immediate feedback you can try reaching out on slack in the platform-dev channel.

@chrismclarke chrismclarke added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Jul 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 20, 2021

Visit the preview URL for this PR (updated for commit 4432751):

https://onearmy-next--pr1191-feat-comments-auth-ldek3nzi.web.app

(expires Thu, 19 Aug 2021 00:34:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@cypress
Copy link

cypress bot commented Jul 20, 2021



Test summary

68 0 0 0Flakiness 0


Run details

Project onearmy-community-platform
Status Passed
Commit 4432751
Started Jul 20, 2021 6:02 AM
Ended Jul 20, 2021 6:09 AM
Duration 07:29 💡
OS Linux Ubuntu - 20.04
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@davehakkens
Copy link
Contributor

oh wauw that is genius!

@chrismclarke chrismclarke merged commit 0752974 into master Jul 20, 2021
@chrismclarke chrismclarke deleted the feat/comments-auth branch July 20, 2021 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: HowTo 📰 Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants