fix: setting countryCode when updating country #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/3868
|
| Run status |
|
| Run duration | 04m 37s |
| Commit |
|
| Committer | Ben Furber |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
73
|
| View all changes introduced in this branch ↗︎ | |
davehakkens
added
the
Review allow-preview ✅
|
Visit the preview URL for this PR (updated for commit 04399dc): https://onearmy-next--pr3868-fix-user-location-se-fe6p76wg.web.app (expires Wed, 30 Oct 2024 12:02:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59 |
|
oe nice visuals flags! 💫 |
jsonDoge
reviewed
Sep 28, 2024
jsonDoge
reviewed
Sep 28, 2024
benfurber
force-pushed
the
fix/user-location-setting
branch
4 times, most recently
from
6cb1569
to
0a51271
Compare
benfurber
force-pushed
the
fix/user-location-setting
branch
from
0a51271
to
9b3f3e0
Compare
|
🎉 This PR is included in version 2.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Setting your country (on the infos settings tab) doesn't set/update your flag icon on comments, etc.
What is the new behavior?
Screen.Recording.2024-09-26.at.15.45.04.mov
Also adds emojis and a little preview to show users how their location will be shown:
