feat: update design of zoom controls on new map #3880
Conversation
onearmy-community-platform
|
||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Run status |
|
| Run duration | 04m 44s |
| Commit |
|
| Committer | Jose |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
75
|
There was a problem hiding this comment.
Fantastic, thank you @JoseAConcepcion!
Minor feedback.
- Make the size of the buttons even bigger. Let's go with 22px font size.
- More spacing in the element - i.e. around the text.
- More spacing around - around the element should be the same size spacing other components on the page have (ideally added to the parent element so it can be added through style props rather than css).
|
Hi @benfurber, the font size of the buttons already were 25px. Should it be higher still? Did you mean the general size of the actual buttons? |
@JoseAConcepcion Ha. I misread the code! Yes I mean the general size of the buttons. If it's 25px already, how's about 30px? |
|
@benfurber its bigger now, increased the size and the padding of the element but I'm not sure it's the spacing of the other elements, for some reason modifying the parent doesn't do the trick :(
PD: While I was zooming in and out discovered that "the report a problem" button disappears, not sure to open an Issue because there are other user buttons to be added in the new design. |
|
Awesome! Thanks @JoseAConcepcion, I'll get this merged in now. Anything else on the issues list take your fancy? |
benfurber
force-pushed
the
3872-zoom-button-style
branch
from
e77d479
to
4e1be1e
Compare
|
@all-contributors add @JoseAConcepcion for code |
|
I've put up a pull request to add @JoseAConcepcion! 🎉 |
|
@benfurber happy to help :) |
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The zoom controls for the new map are currently the default design.
What is the new behavior?
The zoom controls were updated with the correct design.
Does this PR introduce a breaking change?
Git Issues
Closes #3872
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.