Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved how-to guidelines #919

Merged
merged 7 commits into from
Mar 28, 2020
Merged

Improved how-to guidelines #919

merged 7 commits into from
Mar 28, 2020

Conversation

davehakkens
Copy link
Contributor

Added a few extra points + guidelines URL

Added guidelines URL
@cypress
Copy link

cypress bot commented Mar 27, 2020



Test summary

23 7 0 0


Run details

Project onearmy-community-platform
Status Failed
Commit 1f8d3d8 ℹ️
Started Mar 28, 2020 3:36 PM
Ended Mar 28, 2020 3:44 PM
Duration 07:01 💡
OS Linux Ubuntu Linux - 14.04
Browser Electron 78

View run in Cypress Dashboard ➡️


Failures

events.spec.ts Failed
1 [Events] > [List events] > [By Everyone]
2 [Events] > [List events] > [By Authenticated]
3 [Events] > [Filter Events] > [By Everyone]
4 [Events] > [Create an event] > [By Authenticated]
settings.spec.ts Failed
1 [Settings] > [Focus Workplace] > [Editing a new Profile]
2 [Settings] > [Focus Community Builder] > [Edit a new profile]
sign-up.spec.ts Failed
1 [Sign-up] > [By Everyone]

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BenGamma
Copy link
Contributor

I terms of code looks good to me, I just changed the link to a relative path so we could change the domain name if needed.
It's more for the text itself that I have little bits to say :
With your modifications it's like this :
Capture d’écran 2020-03-27 à 08 05 03

Potential changes 1

We keep just one title, either "how does it work" or "how-to guidelines",
We use real emojis en only for the last point.
Capture d’écran 2020-03-27 à 08 06 57

Potential changes 2

We keep just one title, either "how does it work" or "how-to guidelines",
We go full on emojis 🌮 🔢 🤖
Capture d’écran 2020-03-27 à 08 04 29

What do you think ?

@davehakkens
Copy link
Contributor Author

I just copy pasted the text from Kat. thanks for checking.
I'd say full in emoji!

@BenGamma BenGamma merged commit 2cc5224 into master Mar 28, 2020
@BenGamma BenGamma deleted the dave-edits branch March 28, 2020 16:04
@BenGamma BenGamma mentioned this pull request Mar 28, 2020
@davehakkens davehakkens restored the dave-edits branch April 3, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants