Fix pr920 - clear indexDB local cache before automated test #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Merged
|
I don't think the clearing should be necessary, Cypress does this automatically as mentioned: But as long as things are working I'm not too worried either way. |
|
Yep it was clearing the localStorage but not the indexDB cypress-io/cypress#1208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since merge of #920 automated testings build were mysteriously failing, with various errors, always different.
That was linked to the change of the IModerable interface in #920 and the fact that the IndexDB database interfaces cached in the automated browser used by cypress (in my case chromium) was different than the new ones.
In this PR I removed the need of modifiying the interface. We should modify interfaces only in major update cases because it will cause all our user to redownload the datas from db. With approximately 10 000 monthly visitors that will cost a lot of bandwith and more hosting cost too.
In this situation (update a webhook for internal use only), it doesn't appear worth to remove all caching.
Also I added an instruction to clear local indexDB cache at the beggining of the tests.