Uuid fixes #71
Merged
Uuid fixes #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2016
jforissier
approved these changes
Dec 8, 2016
When encoding a UUID as a sequence of bytes, the spec (https://www.ietf.org/rfc/rfc4122.txt) says that the u32, and two u16s should be represented big endian. Before this patch OPTEE always treated them natively. With this patch UUIDs are always converted to/from big endian when communicating with the kernel. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Fixes: OP-TEE/optee_os#858 Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Prior to this patch although GlobalPlatform specifies that TAs and such are identified with UUIDs, we don't format them quite right when turning them into strings. Per https://www.ietf.org/rfc/rfc4122.txt, there should be another hyphen after the first two bytes of clockSeqAndNode. Unfortunately, fixing this breaks compatibility between how TAs are built, and when the OS loads them. With this patch UUID string are formated with the additional hyphen as for instance: f81d4fae-7dec-11d0-a765-00a0c91e6bf6 Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Fixes: OP-TEE/optee_os#857 Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
|
Tag applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OP-TEE/optee_os#857 and OP-TEE/optee_os#858
Depends on OP-TEE/optee_os#1227 and OP-TEE/optee_test#150