Keep assembly functions in separate sections #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jforissier
reviewed
Nov 2, 2017
| @@ -234,6 +233,7 @@ END_FUNC unhandled_cpu | |||
| .endif | |||
| .endm | |||
|
|
|||
| .section .text.reset_vect_table | |||
| @@ -817,6 +819,7 @@ UNWIND( .cantunwind) | |||
| UNWIND( .fnend) | |||
| END_FUNC thread_svc_handler | |||
|
|
|||
| .section .text.thread_vect_table | |||
| @@ -345,6 +346,7 @@ END_FUNC thread_unwind_user_mode | |||
| .endm | |||
|
|
|||
|
|
|||
| .section .text.thread_vect_table | |||
| _core_pos: | ||
| .long get_core_pos - . | ||
|
|
||
| /* |
There was a problem hiding this comment.
Why move this block here? Just cosmetic?
There was a problem hiding this comment.
It's to avoid an assembler error, apparantly the adr instruction can only be performed on symbols in the same section.
| @@ -244,6 +244,7 @@ UNWIND( .cantunwind) | |||
| UNWIND( .fnend) | |||
| END_FUNC sm_fiq_entry | |||
|
|
|||
| .section .text.sm_vect_table | |||
|
"core: arm32: replace _start with reset() function" is needed also for this to have full effect. |
jenswi-linaro
force-pushed
the
asm_func_sections
branch
from
93594c6 to
c2cc553
Compare
|
Rebased |
jforissier
reviewed
Nov 8, 2017
| @@ -210,7 +211,7 @@ UNWIND( .cantunwind) | |||
| msr cpsr, r1 | |||
| bx lr | |||
| UNWIND( .fnend) | |||
| END_FUNC thread_set_abt_sp | |||
| END_FUNC thread_set_und_sp | |||
There was a problem hiding this comment.
Nit: unrelated fix, should be a separate commit
|
|
||
| #else /* defined(CFG_WITH_ARM_TRUSTED_FW) */ | ||
|
|
||
| LOCAL_FUNC reset_secondary , : | ||
| UNWIND( .fnstart) | ||
| UNWIND( .cantunwind) | ||
| ldr r0, =reset_vect_table | ||
| write_vbar r0 |
There was a problem hiding this comment.
Isn't this an unrelated fix? (would deserve its own commit)
jenswi-linaro
force-pushed
the
asm_func_sections
branch
from
c2cc553 to
545e0e6
Compare
|
Split the commits |
|
Thanks for splitting the commits. |
Sets correct end tag for thread_set_und_sp() Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
To get a more fine grained selection of which area (init, paged, unpaged) an assembly function is assigned do the equivalent of -ffunction-sections but in assembly. Some functions has to be in specific places in the binary for a successful boot, link script is updated accordingly. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Renames _start to reset_vect_table and renames reset() to _start() in order to avoid pulling in too much unpaged code via reset_secondary()/cpu_on_handler(). Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Sets reset vector in reset_secondary() to trap unexpected exceptions. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (QEMU v7/v8) Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
jenswi-linaro
force-pushed
the
asm_func_sections
branch
from
545e0e6 to
f46ee4a
Compare
|
Tag applied |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get a more fine grained selection of which area (init, paged,
unpaged) an assembly function is assigned do the equivalent of
-ffunction-sections but in assembly.
Some functions has to be in specific places in the binary for a
successful boot, link script is updated accordingly.
Tested-by: Jens Wiklander jens.wiklander@linaro.org (QEMU v7/v8)
Signed-off-by: Jens Wiklander jens.wiklander@linaro.org