-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plat-ls: Add support for armv8 platform flavour #1941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment below. Anyway:
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Also, could you please add a line to MAINTAINERS.md
? Thanks.
@@ -20,6 +20,10 @@ CFG_BOOT_SYNC_CPU ?= y | |||
CFG_BOOT_SECONDARY_REQUEST ?= y | |||
endif | |||
|
|||
ifeq ($(PLATFORM_FLAVOR),ls1012ardb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be written as:
ifneq (,$(filter $(PLATFORM_FLAVOR),ls1012ardb ls1043ardb))
include core/arch/arm/cpu/cortex-armv8-0.mk
endif
But, you may keep the two ifeq
s if you prefer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not change it for now, When more platforms will be planned to get added, I will change it.
|
|
Updated the MAINTAINERS.md. |
Thanks @pangupta, can you please add the Acked-by: and Reviewed-by: tags? |
Added support for armv8 platform flavour. - PLATFORM = ls-ls1012ardb Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> Reviewed-by: Sumit Garg <sumit.garg@nxp.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org> Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
Added the Acked-by: and Reviewed-by: tags. |
Added support for armv8 platform flavour.
Signed-off-by: Pankaj Gupta pankaj.gupta@nxp.com