Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plat-ls: Add support for armv8 platform flavour #1941

Merged
merged 1 commit into from
Nov 15, 2017
Merged

plat-ls: Add support for armv8 platform flavour #1941

merged 1 commit into from
Nov 15, 2017

Conversation

pangupta
Copy link
Contributor

Added support for armv8 platform flavour.

  • PLATFORM = ls-ls1012ardb

Signed-off-by: Pankaj Gupta pankaj.gupta@nxp.com

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment below. Anyway:
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>

Also, could you please add a line to MAINTAINERS.md? Thanks.

@@ -20,6 +20,10 @@ CFG_BOOT_SYNC_CPU ?= y
CFG_BOOT_SECONDARY_REQUEST ?= y
endif

ifeq ($(PLATFORM_FLAVOR),ls1012ardb)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be written as:

ifneq (,$(filter $(PLATFORM_FLAVOR),ls1012ardb ls1043ardb))
include core/arch/arm/cpu/cortex-armv8-0.mk
endif

But, you may keep the two ifeqs if you prefer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not change it for now, When more platforms will be planned to get added, I will change it.

@jenswi-linaro
Copy link
Contributor

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

@b49020
Copy link
Contributor

b49020 commented Nov 14, 2017

Reviewed-by: Sumit Garg <sumit.garg@nxp.com>

@pangupta
Copy link
Contributor Author

Updated the MAINTAINERS.md.

@jforissier
Copy link
Contributor

Thanks @pangupta, can you please add the Acked-by: and Reviewed-by: tags?

Added support for armv8 platform flavour.
 - PLATFORM = ls-ls1012ardb

Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
Reviewed-by: Sumit Garg <sumit.garg@nxp.com>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
@pangupta
Copy link
Contributor Author

Added the Acked-by: and Reviewed-by: tags.

@jforissier jforissier merged commit 2863328 into OP-TEE:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants