ree_fs_truncate() sync #2099
Merged
ree_fs_truncate() sync #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Needs more investigation, it seems that the new size (new meta-data) is indeed written to disk but for some reason when the object is re-open, the wrong header index is used and the previous header is read (hence the older size is assumed). |
|
Please add jenswi-linaro@430eaf3 It fixes one error. I'm working on the remaining error. |
|
Please add jenswi-linaro@70ae450 It fixes the remaining error. |
jforissier
force-pushed
the
truncate-sync
branch
from
3996b4e
to
b4fffaf
Compare
|
Thanks @jenswi-linaro, works fine now. |
|
Thanks @jforissier @jenswi-linaro . The issue should have been fixed.
|
jforissier
force-pushed
the
truncate-sync
branch
from
b4fffaf
to
0536c00
Compare
Reported-by: Kevin Peng <kevinp@marvell.com> Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
When an object is truncated but the number of blocks is unchanged, only the metadata's length field is modified. The hash tree layer has to be notified so that it knows it has to flush the data before closing the object, otherwise the truncation is lost. Add a function for that purpose: tee_fs_htree_meta_set_dirty(), and call it whenever meta->length is updated. Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
To commit the changes done by ree_fs_truncate() in the dirfile, call commit_dirh_writes() before closing the dirh. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>
Includes the meta data when calculating the hash of the root node to detect changes in file length while number of blocks is unchanged. Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org> Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Fixes: OP-TEE#2094 Reported-by: Kevin Peng <kevinp@marvell.com> Tested-by: Kevin Peng <kevinp@marvell.com> [jf: add Fixes:, Reported-by: and Tested-by: tags] Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
jforissier
force-pushed
the
truncate-sync
branch
from
0536c00
to
d4fd366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.