Fix CAAM RSA inconsistent fails #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementfaure
force-pushed
the
upstream/fix_caam_3657
branch
from
2fee144
to
31dee43
Compare
clementfaure
force-pushed
the
upstream/fix_caam_3657
branch
from
2ef6044
to
d326279
Compare
|
Descriptive macro added for key format in the last commit |
|
@jenswi-linaro Does it look good to you? |
| @@ -73,6 +73,10 @@ struct caam_rsa_keypair { | |||
| struct caambuf qp; /* Private [qp = 1/q mod p] */ | |||
| }; | |||
|
|
|||
| #define RSA_PRIVATE_KEY_FORMAT_1 1 | |||
There was a problem hiding this comment.
I can see why we didn't have these before, since the name of the key format happens to be a number. It's still an improvement though.
There was a problem hiding this comment.
It helps with readability at least.
Tag applied!
Fix the RSA private key format number 3. Signed-off-by: Clement Faure <clement.faure@nxp.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Fix the RSA encoded message length computation when verifying the message. This fixes inconsistent xtest 4006.20 and 4006.32 fails. Signed-off-by: Clement Faure <clement.faure@nxp.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Add descriptive defines for RSA private key formats for a better readability. Signed-off-by: Clement Faure <clement.faure@nxp.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
clementfaure
force-pushed
the
upstream/fix_caam_3657
branch
from
d326279
to
25a89e2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
A small patch set to fix RSA CAAM issue #3657
Thanks!
Clement