Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG for 3.19.0 and collect Tested-by tags. #5550

Merged
merged 2 commits into from
Oct 14, 2022

Conversation

jforissier
Copy link
Contributor

Signed-off-by: Jerome Forissier jerome.forissier@linaro.org

@clementfaure
Copy link
Contributor

Hello @jforissier !

For 4b46e0e8

Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6dlsabresd)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6qsabresd)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6sllevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6sxsabresd)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6ulevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6ullevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6ulzevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx7dsabresd)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx7ulpevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8mmevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8mnevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8mqevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8mpevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8qmmek)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8qxpmek)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8dxlevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8ulpevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx93evk)

@jforissier
Copy link
Contributor Author

For 4b46e0e81:

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (vexpress-qemu_armv8a, GP, PKCS#11)

With one known issue: #5418

@jforissier
Copy link
Contributor Author

For 4b46e0e81:

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (vexpress-qemu_virt, GP, PKCS#11)

@manorit2001
Copy link
Contributor

For 4b46e0e81

Tested-by: Manorit Chawdhry <m-chawdhry@ti.com> (k3-j721e)

@sahilnxp
Copy link
Contributor

Hello

For 4b46e0e81

Tested-by: Sahil Malhotra sahil.malhotra@nxp.com (LS1012A-RDB)
Tested-by: Sahil Malhotra sahil.malhotra@nxp.com (LS1028A-RDB)
Tested-by: Sahil Malhotra sahil.malhotra@nxp.com (LS1088A-RDB)
Tested-by: Sahil Malhotra sahil.malhotra@nxp.com (LS2088A-RDB)
Tested-by: Sahil Malhotra sahil.malhotra@nxp.com (LS1046A-RDB)
Tested-by: Sahil Malhotra sahil.malhotra@nxp.com (LS1043A-RDB)
Tested-by: Sahil Malhotra sahil.malhotra@nxp.com (LX2160A-RDB)
Tested-by: Sahil Malhotra sahil.malhotra@nxp.com (LX2160A-QDS)

@jforissier
Copy link
Contributor Author

For b7563bab0:

Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (hikey-hikey, GP, PKCS#11)

@jenswi-linaro
Copy link
Contributor

For b0ba003:
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (Juno)

@jenswi-linaro
Copy link
Contributor

For 3.19.0-rc1
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (imx-mx8mqevk)

@igoropaniuk
Copy link
Contributor

igoropaniuk commented Oct 11, 2022

For 3.19.0-rc1

Tested-by: Igor Opaniuk <igor.opaniuk@foundries.io> (Poplar)

+-----------------------------------------------------
26307 subtests of which 0 failed
98 test cases of which 0 failed
0 test cases were skipped
TEE test application done!

There is unrelated to OP-TEE OS (rather to Poplar builroot setup) problem, at some point kernel increased in size, so now hitting this issue in U-Boot:

Device 0: unknown device
switch to partitions #0, OK
mmc0(part 0) is current device
Scanning mmc 0:2...
Found /extlinux/extlinux.conf
Retrieving file: /extlinux/extlinux.conf
180 bytes read in 2 ms (87.9 KiB/s)
1:	Buildroot
Retrieving file: /extlinux/../Image
36440576 bytes read in 1614 ms (21.5 MiB/s)
append: mem=1G root=/dev/mmcblk0p3 rootfstype=ext4 rootwait rw earlycon=pl011,0xf8b00000 mmz=ddr,0,0,60M
Retrieving file: /extlinux/../hisilicon/hi3798cv200-poplar.dtb
14390 bytes read in 4 ms (3.4 MiB/s)
## Flattened Device Tree blob at 32200000
   Booting using the fdt blob at 0x32200000
ERROR: FDT image overlaps OS image (OS=0x30000000..0x32360000)
SCRIPT FAILED: continuing...
14390 bytes read in 4 ms (3.4 MiB/s)
BOOTP broadcast 1
DHCP client bound to address 1

Adjusting fdt_addr_r in U-Boot obviously fixes the problem, but as poplar manifest points to mainline U-Boot, tbh I'm not sure how that can be addressed properly (@jforissier @jenswi-linaro could you please provide some input):

  1. U-Boot fork (v2021.07 + fdt_addr_r patch) + poplar.xml pointing to that fork
  2. Play with build/kconfigs/poplar.conf, unsetting unneeded Kconfig symbols to decrease Linux image in size

@jenswi-linaro
Copy link
Contributor

For ecd7f42
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (FVP)

@jenswi-linaro
Copy link
Contributor

@igoropaniuk, this isn't the first time I've seen this kind of error in U-Boot. The solution is often to change the FDT address until things work again, but given that this occurs again and again it would be nice if this was handled automatically by U-Boot instead. Regardless, it seems that the fix should be done in the upstream U-Boot.

OP-TEE itself works and that's most important, so the tested by is good and I guess that's enough for this release. We could if needed add a note of the problem somewhere.

@balint-dobszay-arm
Copy link
Contributor

For 3.19.0-rc1:
Tested-by: Balint Dobszay <balint.dobszay@arm.com> (fvp-ts)

@ricardosalveti
Copy link
Contributor

For ecd7f42:

Tested-by: Ricardo Salveti <ricardo@foundries.io> (imx-mx8mmevk, plug-and-trust v0.4.0)
Tested-by: Ricardo Salveti <ricardo@foundries.io> (ZynqMP, GP, PKCS#11)

While xtest works on imx-mx8mmevk with plug-and-trust (SE05X), it can fail when running in loop, which is fixed by #5541.

@etienne-lms
Copy link
Contributor

Last minute issue on plat-stm32mp1.
I saw a regression on stm32mp15 since #5527 was merged. My fault, i did not test ith the U-Boot used in OP-TEE generated distribution. Since applied, stm32mp15 crashs in U-Boot at boot time, when booting OP-TEE manifest.

I've created #5585 to fix the issue.
With that patch applied:
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1, gp, pkcs11)

I hope it's not too late for the release tag.

@jforissier
Copy link
Contributor Author

I hope it's not too late for the release tag.

No, it's not. I will make the release in an hour or so.

@etienne-lms
Copy link
Contributor

Thanks @jforissier. sorry for that.

Tag fixup (to show which flavors were tested):
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1-157C_DK2, gp, pkcs11)
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1-157C_DK2, gp, pkcs11)

Changes stm32mp1 MP15 variant default configuration for
CFG_EXTERNAL_DT that is now default enabled. This is needed as
mainline U-Boot and Linux may not yet define the necessary
optee nodes in their DT. Therefore prefer external DT be
accessed by default and let external OP-TEE configuration
disable the switch if desired.

This change does not modify MP13 variant default configuration
where CFG_EXTERNAL_DT is default disabled.


Acked-by: Gatien Chevallier <gatien.chevallier@foss.st.com>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
@jforissier
Copy link
Contributor Author

Tag fixup (to show which flavors were tested):
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1-157C_DK2, gp, pkcs11)
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1-157C_DK2, gp, pkcs11)

That is twice the same tag :-/

@etienne-lms
Copy link
Contributor

right!
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1-157C_DK2, gp, pkcs11)
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1-157C_EV1, gp, pkcs11)

Update CHANGELOG for 3.19.0 and collect Tested-by tags.

Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6dlsabresd)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6qsabresd)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6sllevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6sxsabresd)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6ulevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6ullevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx6ulzevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx7dsabresd)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx7ulpevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8mmevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8mnevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8mqevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8mpevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8qmmek)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8qxpmek)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8dxlevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx8ulpevk)
Tested-by: Clement Faure <clement.faure@nxp.com> (imx-mx93evk)
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (vexpress-qemu_armv8a, GP, PKCS#11)
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (vexpress-qemu_virt, GP, PKCS#11)
Tested-by: Manorit Chawdhry <m-chawdhry@ti.com> (k3-j721e)
Tested-by: Sahil Malhotra <sahil.malhotra@nxp.com> (LS1012A-RDB)
Tested-by: Sahil Malhotra <sahil.malhotra@nxp.com> (LS1028A-RDB)
Tested-by: Sahil Malhotra <sahil.malhotra@nxp.com> (LS1088A-RDB)
Tested-by: Sahil Malhotra <sahil.malhotra@nxp.com> (LS2088A-RDB)
Tested-by: Sahil Malhotra <sahil.malhotra@nxp.com> (LS1046A-RDB)
Tested-by: Sahil Malhotra <sahil.malhotra@nxp.com> (LS1043A-RDB)
Tested-by: Sahil Malhotra <sahil.malhotra@nxp.com> (LX2160A-RDB)
Tested-by: Sahil Malhotra <sahil.malhotra@nxp.com> (LX2160A-QDS)
Tested-by: Jerome Forissier <jerome.forissier@linaro.org> (hikey-hikey, GP, PKCS#11)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (Juno)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (imx-mx8mqevk)
Tested-by: Igor Opaniuk <igor.opaniuk@foundries.io> (Poplar)
Tested-by: Jens Wiklander <jens.wiklander@linaro.org> (FVP)
Tested-by: Balint Dobszay <balint.dobszay@arm.com> (fvp-ts)
Tested-by: Ricardo Salveti <ricardo@foundries.io> (imx-mx8mmevk, plug-and-trust v0.4.0)
Tested-by: Ricardo Salveti <ricardo@foundries.io> (ZynqMP, GP, PKCS#11)
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1-157C_DK2, gp, pkcs11)
Tested-by: Etienne Carriere <etienne.carriere@linaro.org> (stm32mp1-157C_EV1, gp, pkcs11)
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
@jforissier jforissier merged commit 045a869 into OP-TEE:master Oct 14, 2022
@jforissier jforissier deleted the changelog-3.19.0 branch October 14, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants