[v4] Relax location of ta head #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the make macro mv-if-changed() into mk/macros.mk to allow use of it in the TA devkit. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Always generate the file holding the list of dynamic symbols a TA should provide. This is needed if CFG_FTRACE_SUPPORT should be changed between two compilations. Use the make macro mv-if-changed() to only update the used file if it will be changed. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Legacy TAs have their TA header in a .ta_head section of the TA binary. However, in commits to follow the TA header will instead be located in the symbol ta_head located somewhere inside the ELF binary. So update the ts_bin_to_c.py script to support the updated format. Acked-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Legacy TAs has their TA header as at the load address of the TA binary. However, in commits to follow the TA header will instead be located in the symbol ta_head located somewhere inside the ELF binary. So update the ldelf to support the updated format while still supporting legacy TAs. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
TAs where required to have the ta_head as at the load address of the TA prior to this patch. This makes the linker script slightly more complicated and also confuses GDB so that an offset must be applied to the load address of the TA when using GDB for debugging. So allow that ta_head symbol to reside anywhere in the ELF binary and also add ta_head to the .dynsym section to make sure that tools and ldelf can find the symbol. This change requires prior updates to tools and ldelf. Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
|
Could we have a prefix in the PR subject to identify more easily the for-4.0.0 stuff? Such as |
jenswi-linaro
changed the title
Good idea, done. |
etienne-lms
reviewed
Sep 25, 2023
| @@ -37,17 +37,18 @@ endif | |||
| link-ldflags += --as-needed # Do not add dependency on unused shlib | |||
| link-ldflags += $(link-ldflags$(sm)) | |||
|
|
|||
| $(link-out-dir$(sm))/dyn_list: | |||
| $(link-out-dir$(sm))/dyn_list: FORCE | |||
There was a problem hiding this comment.
instead of FORCE, could there be a dependancy on $(conf-file)?
There was a problem hiding this comment.
I'm not sure that is set in the TA dev-kit.
There was a problem hiding this comment.
No, I don't think it's set in the TA dev-kit, but that's also why we're using mv-if-changed() below so that we don't trigger unnecessary rebuilds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jenswi-linaro#10 applied to upstream instead of my private fork.
This is part of #6032