compiler.h: only use __no_stack_protector if supported by the compiler #7118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-mailhol
force-pushed
the
check_for_no-stack-protector-support
branch
2 times, most recently
from
bca8821
to
8fdcb76
Compare
|
|
The __attribute__((no_stack_protector)) was introduced in GCC 11. Building a TA with a version of GCC older than that would trigger a -Wattributes warning on the ta/user_ta_header.c file. Use __has_attribute() to check support of the no_stack_protector attribute before using it. If not supported, define the __no_stack_protector alias as a NOP. Fixes: e3fb2bd ("compiler.h: add __no_stack_protector") Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
vincent-mailhol
force-pushed
the
check_for_no-stack-protector-support
branch
from
8fdcb76
to
d93b653
Compare
Thanks for the acknowledgement. Tag applied in d93b653. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
__attribute__((no_stack_protector))was introduced in GCC 11. Building a TA with an older version of GCC would trigger a-Wattributeswarning on theta/user_ta_header.cfile.Use
__has_attribute()to check for the support of theno_stack_protectorattribute before using it. If not supported, define the__no_stack_protectoralias as a NOP.Fixes: e3fb2bd ("compiler.h: add __no_stack_protector")
Note: This
no_stack_protectoris the only troublesome attribute in my set up (GCC 9.4.0). Let me know if you want to also add a__has_attribute()guard to the other attributes and I will do so.