xtest: asymm signature with a too small buffer (regression 4006/4016 + pkcs11 1025) #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that providing a too small signature output buffer makes the GP TEE Internal Core API to return TEE_ERROR_SHORT_BUFFER as expected. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Test that providing a too small signature output buffer for an ED25519 signature makes the GP TEE Internal Core API to return TEE_ERROR_SHORT_BUFFER as expected and that providing a bigger buffer returns the expected signature size. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Test that providing a too small signature output buffer for an ED25519 sign operation makes the Cryptoki API function to return CKR_OK (nul size case) or CKR_BUFFER_TOO_SMALL (non-nul too small size) as expected and that providing a bigger buffer returns the expected signature size. Signed-off-by: Etienne Carriere <etienne.carriere@foss.st.com> Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
etienne-lms
force-pushed
the
sign-small-buffer
branch
from
e579fa9 to
9ec38f2
Compare
|
Thanks. Review tag applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue reported and fixed by OP-TEE/optee_os#7162, I add some tests to request asymmetric signature providing a too small signature output buffer.
Tested with both CFG_CRYPTOLIB_NAME={tomcrypt|mbedtls}`.
Changes in regression_4006 covers the RSA/ECC cases, already handled in OP-TEE even before tag 4.4.0.
Changes in regresison_4016 and pkcs11_1025 covers the ED25519 cases and require OP-TEE/optee_os#7162 (recently merged) to succeed.