Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update container #767

Merged
merged 1 commit into from
Dec 17, 2024
Merged

ci: update container #767

merged 1 commit into from
Dec 17, 2024

Conversation

jforissier
Copy link
Contributor

Update the CI container to jforissier/optee_os_ci:qemu_check [1] which is the latest one, usable for both 32-bit and 64-bit ARM, and which is used by the optee_os CI [2]. This one should be able to build QEMU 9.2.0 without any issue contrary to the current one which causes:

*** Ouch! ***

found no usable tomli, please install it

Link: https://github.com/jforissier/docker_optee_os_ci/tree/qemu_check [1]
Link: https://github.com/OP-TEE/optee_os/blob/4.4.0/.github/workflows/ci.yml#L319 [2]

@jenswi-linaro
Copy link
Contributor

Acked-by: Jens Wiklander <jens.wiklander@linaro.org>

@jforissier jforissier force-pushed the ci-container branch 3 times, most recently from db09877 to df42045 Compare December 17, 2024 12:54
@etienne-lms
Copy link
Contributor

Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> FWIW.
That said, it seems both optee_os CI still have the issue and the P-R also failed to build Qemu.

@jforissier
Copy link
Contributor Author

Acked-by: Etienne Carriere <etienne.carriere@foss.st.com> FWIW. That said, it seems both optee_os CI still have the issue and the P-R also failed to build Qemu.

Correct. I also need to add the python3-tomli package to the image. Using the same image for CI here and in optee_os is a good thing anyways. Thanks for the tag.

@etienne-lms
Copy link
Contributor

Do you mean we should restart the CI jobs that failed on optee_os repo?

@jforissier
Copy link
Contributor Author

Yes, but I need to push the updated image to the Docker hub first. The upload is in progress.

Update the CI container to jforissier/optee_os_ci:qemu_check [1] which
is the latest one, usable for both 32-bit and 64-bit ARM, and which is
used by the optee_os CI [2]. This one should be able to build QEMU
9.2.0 without any issue contrary to the current one which causes:

 *** Ouch! ***

 found no usable tomli, please install it

Link: https://github.com/jforissier/docker_optee_os_ci/tree/qemu_check [1]
Link: https://github.com/OP-TEE/optee_os/blob/4.4.0/.github/workflows/ci.yml#L319 [2]
Signed-off-by: Jerome Forissier <jerome.forissier@linaro.org>
Acked-by: Jens Wiklander <jens.wiklander@linaro.org>
Acked-by: Etienne Carriere <etienne.carriere@foss.st.com>
@jforissier
Copy link
Contributor Author

Docker image updated on dockerhub (with the missing python3-tomli package added). CI should hopefully pass. I will restart the failed jobs in optee_os.

@jforissier
Copy link
Contributor Author

Needs OP-TEE/build#799

@jforissier jforissier merged commit ced6e81 into OP-TEE:master Dec 17, 2024
1 check passed
@jforissier jforissier deleted the ci-container branch December 17, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants