-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utilies to update data objects moved to utils #190
Conversation
10c0b15
to
6fae4d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
Could you do a grep search to make sure if all calls related to update_predicted_values
and update_atom_features
are updated accordingly? Thanks.
@pzhanggit |
46bde83
to
c7ff987
Compare
Regarding the citest failure, I ran on my local machine and found test_datasetclass_inheritance.py is causing a problem. It looks like there is a conflict in using ddp inside pytest with mutliple test cases. I will look for some examples in the internet. |
Fix for the CI test error
@jychoi-hpc @pzhanggit |
* utilies to update data objects moved to utils * pytest to check class inheritance of dataset from abstractrawdataset * reformatting * merge conflicts resolved * hasattr call fixed * formatting * fix for the ci test error --------- Co-authored-by: Choi <choij@ornl.gov>
No description provided.