Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations missing from epsg:4258 to epsg:7415 #3219

Closed
snowman2 opened this issue Jun 3, 2022 · 2 comments
Closed

Operations missing from epsg:4258 to epsg:7415 #3219

snowman2 opened this issue Jun 3, 2022 · 2 comments

Comments

@snowman2
Copy link
Contributor

snowman2 commented Jun 3, 2022

From: pyproj4/pyproj#1083

git bisect points to: 6a731e3
But, not clear to me why that would cause this change.

Example of problem

./projinfo
Rel. 9.1.0, September 1st, 2022
...
PROJ_NETWORK=ON ./projinfo -s "epsg:4258" -t "epsg:7415" -o PROJ
Candidate operations found: 2
-------------------------------------
Operation No. 1:

unknown id, Inverse of Amersfoort to ETRS89 (9) + RD New, 0.001 m, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=hgridshift +grids=nl_nsgi_rdtrans2018.tif
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_rdtrans2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_rdtrans2018.tif

-------------------------------------
Operation No. 2:

unknown id, Inverse of Amersfoort to ETRS89 (8) + RD New, 0.25 m, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +proj=push +v_3
  +step +proj=cart +ellps=GRS80
  +step +inv +proj=helmert +x=565.7381 +y=50.4018 +z=465.2904
        +rx=0.395025981036064 +ry=-0.330772431242031 +rz=1.87607329462821
        +s=4.07244 +convention=coordinate_frame
  +step +inv +proj=cart +ellps=bessel
  +step +proj=pop +v_3
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

projinfo
Rel. 9.0.0, March 1st, 2022
...
PROJ_NETWORK=ON projinfo -s "epsg:4258" -t "epsg:7415" -o PROJ
Candidate operations found: 6
-------------------------------------
Operation No. 1:

unknown id, ETRS89 to NAP height (2) + Inverse of Amersfoort to ETRS89 (9) + RD New, 0.002 m, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=vgridshift +grids=nl_nsgi_nlgeo2018.tif +multiplier=1
  +step +inv +proj=hgridshift +grids=nl_nsgi_rdtrans2018.tif
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_nlgeo2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_nlgeo2018.tif
Grid nl_nsgi_rdtrans2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_rdtrans2018.tif

-------------------------------------
Operation No. 2:

unknown id, ETRS89 to NAP height (2) + Inverse of Amersfoort to ETRS89 (8) + RD New, 0.251 m, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=vgridshift +grids=nl_nsgi_nlgeo2018.tif +multiplier=1
  +step +proj=push +v_3
  +step +proj=cart +ellps=GRS80
  +step +inv +proj=helmert +x=565.7381 +y=50.4018 +z=465.2904
        +rx=0.395025981036064 +ry=-0.330772431242031 +rz=1.87607329462821
        +s=4.07244 +convention=coordinate_frame
  +step +inv +proj=cart +ellps=bessel
  +step +proj=pop +v_3
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_nlgeo2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_nlgeo2018.tif

-------------------------------------
Operation No. 3:

unknown id, ETRS89 to NAP height (2) + Inverse of Ballpark geographic offset from Amersfoort to ETRS89 + RD New, unknown accuracy, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., has ballpark transformation, at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=vgridshift +grids=nl_nsgi_nlgeo2018.tif +multiplier=1
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_nlgeo2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_nlgeo2018.tif

-------------------------------------
Operation No. 4:

unknown id, Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Amersfoort to ETRS89 (9) + RD New, unknown accuracy, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., has ballpark transformation, at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=hgridshift +grids=nl_nsgi_rdtrans2018.tif
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_rdtrans2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_rdtrans2018.tif

-------------------------------------
Operation No. 5:

unknown id, Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Amersfoort to ETRS89 (8) + RD New, unknown accuracy, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., has ballpark transformation

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +proj=push +v_3
  +step +proj=cart +ellps=GRS80
  +step +inv +proj=helmert +x=565.7381 +y=50.4018 +z=465.2904
        +rx=0.395025981036064 +ry=-0.330772431242031 +rz=1.87607329462821
        +s=4.07244 +convention=coordinate_frame
  +step +inv +proj=cart +ellps=bessel
  +step +proj=pop +v_3
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

-------------------------------------
Operation No. 6:

unknown id, Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Ballpark geographic offset from Amersfoort to ETRS89 + RD New, unknown accuracy, World, has ballpark transformation

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Problem description

Not sure if there is a problem, just noticed that this is different. Wanted to make sure the behavior change is expected.

Environment Information

  • See example above

Installation method

  • from source
@snowman2 snowman2 added the bug label Jun 3, 2022
@rouault
Copy link
Member

rouault commented Jun 3, 2022

Are you really sure about your bisection session ? I can't explain why the commit you point to would have this effect. I would say 3e7984f is a better candidate

Anyway, the new results are correct. EPSG:4258 is a 2D CRS, hence using the vertical grids doesn't make sense. If you use EPSG:4937 instead, you'll get the past results

@rouault rouault removed the bug label Jun 3, 2022
@rouault rouault closed this as completed Jun 3, 2022
@snowman2
Copy link
Contributor Author

snowman2 commented Jun 3, 2022

Are you really sure about your bisection session ?

There is definitely some room for me to have made a mistake. Thanks for looking into it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants