Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: test_transformer_group__get_transform_crs failing count #1083

Closed
snowman2 opened this issue Jun 3, 2022 · 2 comments · Fixed by #1084
Closed

TST: test_transformer_group__get_transform_crs failing count #1083

snowman2 opened this issue Jun 3, 2022 · 2 comments · Fixed by #1084
Labels
test Test related issues

Comments

@snowman2
Copy link
Member

snowman2 commented Jun 3, 2022

https://github.com/pyproj4/pyproj/runs/6640103663

Only 2 transformers available. Previously 6.

From git bisect with PROJ:

6a731e38fa311e7345baeb40d714d334e394db1e is the first bad commit
commit 6a731e38fa311e7345baeb40d714d334e394db1e
Author: Even Rouault <even.rouault@spatialys.com>
Date:   Thu Mar 24 22:10:32 2022 +0100

    WKT2 parser: add special case for slightly non-conformant WKT output of epsg.org regarding PARAMETER["EPSG code for Interpolation CRS",crs_code,ID[EPSG,1048]]

 src/lib_proj.cmake          |    2 +-
 src/proj_constants.h        |    4 +
 src/wkt2_generated_parser.c | 2319 ++++++++++++++++++++++---------------------
 src/wkt2_generated_parser.h |    9 +-
 src/wkt2_grammar.y          |   23 +-
 src/wkt2_parser.cpp         |   10 +
 6 files changed, 1206 insertions(+), 1161 deletions(-)

OSGeo/PROJ@6a731e3

After change:

>>> from pyproj.transformer import TransformerGroup
>>> tg = TransformerGroup("epsg:4258", "epsg:7415")
>>> tg.transformers
[<Concatenated Operation Transformer: pipeline>
Description: Inverse of Amersfoort to ETRS89 (9) + RD New
Area of Use:
- name: Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.
- bounds: (3.2, 50.75, 7.22, 53.7), <Concatenated Operation Transformer: pipeline>
Description: Inverse of Amersfoort to ETRS89 (8) + RD New
Area of Use:
- name: Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.
- bounds: (3.2, 50.75, 7.22, 53.7)]

PROJ 9.0.0:

>>> from pyproj.transformer import TransformerGroup
>>> tg = TransformerGroup("epsg:4258", "epsg:7415")
>>> tg.transformers
[<Concatenated Operation Transformer: pipeline>
Description: ETRS89 to NAP height (2) + Inverse of Amersfoort to ETRS89 (9) + RD New
Area of Use:
- name: Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.
- bounds: (3.2, 50.75, 7.22, 53.7), <Concatenated Operation Transformer: pipeline>
Description: ETRS89 to NAP height (2) + Inverse of Amersfoort to ETRS89 (8) + RD New
Area of Use:
- name: Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.
- bounds: (3.2, 50.75, 7.22, 53.7), <Concatenated Operation Transformer: pipeline>
Description: ETRS89 to NAP height (2) + Inverse of Ballpark geographic offset from Amersfoort to ETRS89 + RD New
Area of Use:
- name: Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.
- bounds: (3.2, 50.75, 7.22, 53.7), <Concatenated Operation Transformer: pipeline>
Description: Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Amersfoort to ETRS89 (9) + RD New
Area of Use:
- name: Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.
- bounds: (3.2, 50.75, 7.22, 53.7), <Concatenated Operation Transformer: pipeline>
Description: Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Amersfoort to ETRS89 (8) + RD New
Area of Use:
- name: Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.
- bounds: (3.2, 50.75, 7.22, 53.7), <Concatenated Operation Transformer: pipeline>
Description: Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Ballpark geographic offset from Amersfoort to ETRS89 + RD New
Area of Use:
- name: World
- bounds: (-180.0, -90.0, 180.0, 90.0)]
@snowman2
Copy link
Member Author

snowman2 commented Jun 3, 2022

Seems to be consistent with the behavior in PROJ:

./projinfo
Rel. 9.1.0, September 1st, 2022
...
PROJ_NETWORK=ON ./projinfo -s "epsg:4258" -t "epsg:7415" -o PROJ
Candidate operations found: 2
-------------------------------------
Operation No. 1:

unknown id, Inverse of Amersfoort to ETRS89 (9) + RD New, 0.001 m, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=hgridshift +grids=nl_nsgi_rdtrans2018.tif
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_rdtrans2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_rdtrans2018.tif

-------------------------------------
Operation No. 2:

unknown id, Inverse of Amersfoort to ETRS89 (8) + RD New, 0.25 m, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone.

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +proj=push +v_3
  +step +proj=cart +ellps=GRS80
  +step +inv +proj=helmert +x=565.7381 +y=50.4018 +z=465.2904
        +rx=0.395025981036064 +ry=-0.330772431242031 +rz=1.87607329462821
        +s=4.07244 +convention=coordinate_frame
  +step +inv +proj=cart +ellps=bessel
  +step +proj=pop +v_3
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

projinfo
Rel. 9.0.0, March 1st, 2022
...
PROJ_NETWORK=ON projinfo -s "epsg:4258" -t "epsg:7415" -o PROJ
Candidate operations found: 6
-------------------------------------
Operation No. 1:

unknown id, ETRS89 to NAP height (2) + Inverse of Amersfoort to ETRS89 (9) + RD New, 0.002 m, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=vgridshift +grids=nl_nsgi_nlgeo2018.tif +multiplier=1
  +step +inv +proj=hgridshift +grids=nl_nsgi_rdtrans2018.tif
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_nlgeo2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_nlgeo2018.tif
Grid nl_nsgi_rdtrans2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_rdtrans2018.tif

-------------------------------------
Operation No. 2:

unknown id, ETRS89 to NAP height (2) + Inverse of Amersfoort to ETRS89 (8) + RD New, 0.251 m, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=vgridshift +grids=nl_nsgi_nlgeo2018.tif +multiplier=1
  +step +proj=push +v_3
  +step +proj=cart +ellps=GRS80
  +step +inv +proj=helmert +x=565.7381 +y=50.4018 +z=465.2904
        +rx=0.395025981036064 +ry=-0.330772431242031 +rz=1.87607329462821
        +s=4.07244 +convention=coordinate_frame
  +step +inv +proj=cart +ellps=bessel
  +step +proj=pop +v_3
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_nlgeo2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_nlgeo2018.tif

-------------------------------------
Operation No. 3:

unknown id, ETRS89 to NAP height (2) + Inverse of Ballpark geographic offset from Amersfoort to ETRS89 + RD New, unknown accuracy, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., has ballpark transformation, at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=vgridshift +grids=nl_nsgi_nlgeo2018.tif +multiplier=1
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_nlgeo2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_nlgeo2018.tif

-------------------------------------
Operation No. 4:

unknown id, Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Amersfoort to ETRS89 (9) + RD New, unknown accuracy, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., has ballpark transformation, at least one grid missing

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +inv +proj=hgridshift +grids=nl_nsgi_rdtrans2018.tif
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

Grid nl_nsgi_rdtrans2018.tif needed but not found on the system. Can be obtained at https://cdn.proj.org/nl_nsgi_rdtrans2018.tif

-------------------------------------
Operation No. 5:

unknown id, Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Amersfoort to ETRS89 (8) + RD New, unknown accuracy, Netherlands - onshore, including Waddenzee, Dutch Wadden Islands and 12-mile offshore coastal zone., has ballpark transformation

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +proj=push +v_3
  +step +proj=cart +ellps=GRS80
  +step +inv +proj=helmert +x=565.7381 +y=50.4018 +z=465.2904
        +rx=0.395025981036064 +ry=-0.330772431242031 +rz=1.87607329462821
        +s=4.07244 +convention=coordinate_frame
  +step +inv +proj=cart +ellps=bessel
  +step +proj=pop +v_3
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

-------------------------------------
Operation No. 6:

unknown id, Inverse of Transformation from NAP height to ETRS89 (ballpark vertical transformation, without ellipsoid height to vertical height correction) + Inverse of Ballpark geographic offset from Amersfoort to ETRS89 + RD New, unknown accuracy, World, has ballpark transformation

PROJ string:
+proj=pipeline
  +step +proj=axisswap +order=2,1
  +step +proj=unitconvert +xy_in=deg +xy_out=rad
  +step +proj=sterea +lat_0=52.1561605555556 +lon_0=5.38763888888889 +k=0.9999079
        +x_0=155000 +y_0=463000 +ellps=bessel

@snowman2
Copy link
Member Author

snowman2 commented Jun 5, 2022

OSGeo/PROJ#3219 (comment)

More likely related to: OSGeo/PROJ#3119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Test related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant